search

daphtdazz / WebBLE

iOS WebBluetooth Polyfill
Other
113 stars 39 forks source link

writeValueWithoutResponse support implemented #52

Closed steffenmauch closed 1 year ago

steffenmauch commented 2 years ago

This patch adds the writeValueWithoutResponse support for WebBLE

daphtdazz commented 2 years ago

Hey @steffenmauch , thanks for this, have you got a device you've been testing with? If so would you be able to add a folder for it in DeviceTests, like the existing Puck.js test, and add a test case for it? I want to try and avoid adding code without tests now, and it is going to be valuable to start accumulating a library of tests for different devices. I will try and review the code at the weekend.

steffenmauch commented 2 years ago

Hey, I do have a device but until now, that device is not published. Is this a criteria for adding it?

steffenmauch commented 2 years ago

Hey @daphtdazz, do you see any change to merge this or do I have to provide you a device where you can test with?

daphtdazz commented 1 year ago

Closing since I have now implemented this and writeValueWithResponse in 59 (and this is now released as version 1.7.0 of WebBLE on the app store).