search

dapphub / ds-proxy

a proxy object that can compose transactions on owner's behalf
https://dapp.tools/dappsys/ds-proxy.html
GNU General Public License v3.0
311 stars 76 forks source link

Add well-defined paths for imports (truffle compatibility) #17

Closed Jake-Gillberg closed 5 years ago

Jake-Gillberg commented 5 years ago

I know this messes up the beautified import statements, but this way I can add ds-proxy as a submodule to a truffle project and everything works swimmingly. It also doesn't appear to mess with dapp build or dapp test. Example project here: https://github.com/CirclesUBI/circles-contracts/tree/test-circles-person

rainbreak commented 5 years ago

lib is configurable by an environment variable DAPP_LIB so this won't work in general

rainbreak commented 5 years ago

We have https://github.com/dapphub/dappsys-monolithic which is usable in a truffle project, maybe we should just add ds-proxy to that.

rainbreak commented 5 years ago

Or consider using dapp for the circles work.

Jake-Gillberg commented 5 years ago

Considered using dapp for the circles work, but we wanted js tests to do things like this: https://github.com/CirclesUBI/circles-contracts/blob/master/test/TimeIssuedToken.test.js#L29

rainbreak commented 5 years ago

@Jake-Gillberg ds-proxy is now in https://github.com/dapphub/dappsys-monolithic, which I assume will fix your usage problem (? :)), so I'll close this.