search

dapphub / ds-proxy

a proxy object that can compose transactions on owner's behalf
https://dapp.tools/dappsys/ds-proxy.html
GNU General Public License v3.0
311 stars 76 forks source link

Make DSProxyFactory returns an address instead of DSProxy #21

Closed gbalabasquer closed 5 years ago

gbalabasquer commented 5 years ago

We are having an issue when extending DSProxy and DSProxyFactory. As the factory returns a DSProxy is not possible to rewrite the build functions without having to also returns a DSProxy. In this case we want to return a class that inherits from DSProxy. I'd suggest to return an address to make it more compatible.

gbalabasquer commented 5 years ago

@NiklasKunkel @rainbreak thoughts?

NiklasKunkel commented 5 years ago

I'm okay with this as it would make DSProxy more composable. Do you see most usecases/integrations for DSProxy using extendable versions rather than the primitive?

gbalabasquer commented 5 years ago

Actually working now in the CdpHandler which extends from the DSProxy.