dappnode / DAppNode

General repository of the project dappnode
GNU General Public License v3.0
588 stars 104 forks source link

Cosmos Package doesn't work? #503

Closed Pol-Lanski closed 1 year ago

Pol-Lanski commented 2 years ago

Cosmos seems to not be working and not even propagating properly.

Error downloading cosmos.public.dappnode.eth release from IPFS: Error validating compose file with dappnode requirements:
Error: Error downloading cosmos.public.dappnode.eth release from IPFS: Error validating compose file with dappnode requirements:

service cosmos.public.dappnode.eth has key tty that is not allowed. Allowed keys are: cap_add,cap_drop,command,depends_on,devices,entrypoint,environment,expose,extra_hosts,healthcheck,labels,logging,network_mode,networks,ports,privileged,restart,stop_grace_period,stop_signal,user,volumes,working_dir,security_opt,image,build,volumes,environment,pid,container_name,dns,ulimits,deploy
    at validateDappnodeCompose (/usr/src/app/webpack:/node_modules/@dappnode/dappnodesdk/dist/files/compose/validateDappnodeCompose.js:32:1)
    at /usr/src/app/webpack:/@dappnode/dappmanager/src/modules/release/ipfs/downloadRelease.ts:79:32
    at Generator.next (<anonymous>)
    at fulfilled (/usr/src/app/index.js:395467:58)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Error downloading cosmos.public.dappnode.eth release from IPFS: Error validating compose file with dappnode requirements:

service cosmos.public.dappnode.eth has key tty that is not allowed. Allowed keys are: cap_add,cap_drop,command,depends_on,devices,entrypoint,environment,expose,extra_hosts,healthcheck,labels,logging,network_mode,networks,ports,privileged,restart,stop_grace_period,stop_signal,user,volumes,working_dir,security_opt,image,build,volumes,environment,pid,container_name,dns,ulimits,deploy
    at http://my.dappnode/static/js/main.7777d745.js:2:10071
    at l (http://my.dappnode/static/js/main.7777d745.js:2:497403)
    at Generator._invoke (http://my.dappnode/static/js/main.7777d745.js:2:497191)
    at Generator.next (http://my.dappnode/static/js/main.7777d745.js:2:497832)
    at r (http://my.dappnode/static/js/main.7777d745.js:2:616449)
    at s (http://my.dappnode/static/js/main.7777d745.js:2:616652)
    at http://my.dappnode/static/js/main.7777d745.js:2:616711
    at new Promise (<anonymous>)
    at http://my.dappnode/static/js/main.7777d745.js:2:616592
    at p (http://my.dappnode/static/js/main.7777d745.js:2:9888)
pablomendezroyo commented 2 years ago

The issue is the compose file used in the cosmos package published. It is not allowed to use the compose key tty. Keys allowed are: cap_add,cap_drop,command,depends_on,devices,entrypoint,environment,expose,extra_hosts,healthcheck,labels,logging,network_mode,networks,ports,privileged,restart,stop_grace_period,stop_signal,user,volumes,working_dir,security_opt,image,build,volumes,environment,pid,container_name,dns,ulimits,deploy

If someone wants to use that key, should open an issue here explaining why it is needed.

If aproved, there will be a new sdk release and new dappmanager release, that would allow this compose key feature

Pol-Lanski commented 2 years ago

Nice! Thank you for this amazing explanation! Was the limitation of the tty key introduced recently? I'm trying to figure out why we had a package that used to work and now it doesn't work.

pablomendezroyo commented 2 years ago

When creating this docker-safe whitelist of keys it may not take into account the public packages, so that could be the reason why cosmos stopped working.

I have opened an issue at their repo to get to the end of this https://github.com/Colm3na/DAppNodePackage-cosmos/issues/5

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

alexpeterson91 commented 1 year ago

@pablomendezroyo Any word from Colmena?

pablomendezroyo commented 1 year ago

Not at all

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

stale[bot] commented 1 year ago

This issue or pull request has been automatically been closed due to inactivity.