dapr / components-contrib

Community driven, reusable components for distributed apps

Apache License 2.0

549 stars 481 forks source link

Fix kafka metadata to HTTP headers conversion of invalid characters #3511

Closed antontroshin closed 3 months ago

antontroshin commented 3 months ago

Description

Sending special characters in Kafka message metadata will cause an error when metadata is converted to HTTP headers. Error:

WARN[0009] Error processing Kafka message: topic/0/13 [key=]. Error: error returned from app channel while sending pub/sub event to app: retriable error occurred: Post "http://127.0.0.1:56012/handle-message": net/http: invalid header field value for "My-Header". Retrying...

Go validates header value using the function ValidHeaderFieldValue, for reference and allowed format, see more here

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #3503

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]