dapr / dotnet-sdk

Dapr SDK for .NET

Apache License 2.0

1.12k stars 340 forks source link

Facility to provide interface while registering actors #1350

Open siri-varma opened 2 months ago

siri-varma commented 2 months ago

Description

Added facility to provide Interface types while registering Actors.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1341

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

[X] Code compiles correctly
[X] Created/updated tests
[X] Extended the documentation

siri-varma commented 2 months ago

@philliphoff @cgillum Would you folks be able to help with approving the workflows please ?

WhitWaldo commented 1 month ago

@siri-varma All in all, I think this looks fine, but I think it'd be helpful to have documentation calling this out as it might be unclear to someone why they're experiencing an exception when implementing an interface that doesn't itself ultimately inherit from an IActor parent.

Otherwise, I think all the code looks fine. If you could write up a few words about it in this section, I'd be happy to accept this.

siri-varma commented 1 month ago

@WhitWaldo I updated the md file. Let me know if it looks good. Thanks

WhitWaldo commented 1 month ago

This will also close #694