dariogoetz / keyboard_layout_optimizer

A keyboard layout optimizer supporting multiple layers. Implemented in Rust.
https://dariogoetz.github.io/keyboard_layout_optimizer/
GNU General Public License v3.0
90 stars 15 forks source link

`ngram_merge`: order of arguments #46

Closed mekeor closed 2 years ago

mekeor commented 2 years ago

The ngram_merge --help claims to use a different order than it really does:

$ ngram_merge --help                                                  
USAGE:
    ngram_merge <OUT> [COMPONENTS]...

$ ngram_merge output input1:1 input2:2 input3:3
thread 'main' panicked at 'index out of bounds: the len is 1 but the index is 1', evolve_keyboard_layout/src/bin/ngram_merge.rs:18:36
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

$ ngram_merge input1:1 input2:2 input3:3 output
$ echo $?
0
dariogoetz commented 2 years ago

Good catch. I reversed the order of the arguments for better consistency in 72cc29572ab382f79af43eaf111a21e7246dab38.