darklordabc / Legends-of-Dota-Redux

A Custom Game for Dota 2
http://steamcommunity.com/sharedfiles/filedetails/?id=786348190
52 stars 35 forks source link

Valve fixed status resistance #1497

Closed edotenseilove closed 6 years ago

edotenseilove commented 6 years ago

Valve fixed MODIFIER_PROPERTY_STATUS_RESISTANCE_STACKING not working and not showing in Hud I have made some tests and it realy works I tried to change basic tenacity bonus ability to provide STATUS_RESISTANCE instand of tenacity and then i changed back aeon disk consumble and when i test it in a real game it was working

Wouterz90 commented 6 years ago

Can you make a pr for this?

edotenseilove commented 6 years ago

image here is the picture I have Tenacity OP changed from providing tenacity to Status resistance and I changed back aeon disk consumable back too and as you can see on the picture I have 96.3 % status resistance

edotenseilove commented 6 years ago

and for the basic tenacity bonus i used: function modifier_basic_tenacity_bonus_op:DeclareFunctions() local funcs = { MODIFIER_PROPERTY_STATUS_RESISTANCE_STACKING, }

return funcs

end

function modifier_basic_tenacity_bonus_op:GetModifierStatusResistanceStacking() if self:GetCaster():PassivesDisabled() then return 0 end return self:GetAbility():GetSpecialValueFor("tenacity_bonus") end

edotenseilove commented 6 years ago

At first I checked the latest update for Dota Imba And there was this line : Replaced Tenacity with Status Resistance (should only change how DoT affected heroes, also now you can see your status resistance on HUD) and I was wondering that was not possible before so i had to immediately test it

Wouterz90 commented 6 years ago

Which is nice of you, and my question was if you could make a pull request for it here, so I can merge it in the next update.

edotenseilove commented 6 years ago

Done I am not Sure if I done it correctly since it is the first Pull request that i created

Wouterz90 commented 6 years ago

Looks good! Thanks!