search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.61k stars 1.13k forks source link

[dt 4.7.0] "cannot get iop-order" bug by selective paste #16441

Closed s7habo closed 6 months ago

s7habo commented 6 months ago

Describe the bug

If you use the "selective paste" function, the photo is completely distorted and the terminal shows the message "cannot get iop-order" for the instances of the modules you have changed.

Steps to reproduce

  1. Make a change in one of the modules (here the exposure):

grafik

  1. Go to the lighttable, choose either selective copy or copy option.
  2. Select another photo and click on selective paste.
  3. Without changing anything, click on OK :

grafik

  1. The photo is completely distorted and...

grafik

...in the terminal you see "cannot get iop-order for exposure instance 1"

grafik

Expected behavior

No response

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

self compiled

darktable version

4.7.0+713~g11546b30a

What OS are you using?

Linux

What is the version of your OS?

Ubuntu Studio 22.04

Describe your system?

Operating System: Ubuntu Studio 22.04 KDE Plasma Version: 5.24.7 KDE Frameworks Version: 5.92.0 Qt Version: 5.15.3 Kernel Version: 5.19.0-1028-lowlatency (64-bit) Graphics Platform: X11 Processors: 8 × Intel® Core™ i7-7700K CPU @ 4.20GHz Memory: 31.3 GiB of RAM Graphics Processor: NVIDIA GeForce GTX 1070/PCIe/SSE2

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

NVIDIA GeForce GTX 1070/PCIe/SSE2, G Driver 535.129.03

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

TurboGit commented 6 months ago

I cannot reproduce...

s7habo commented 6 months ago

Strange. I have just recompiled the darktable and the problem is still there..

https://github.com/darktable-org/darktable/assets/38165484/a3207fae-9014-470e-b46f-c525bdc3baf2

Note that the paste option works. The problem only affects selective paste.

s7habo commented 6 months ago

I have the same issue with the latest master git version from OBS: 4.7.0~git720.7baaaf11-1+11426.1

s7habo commented 6 months ago

I just realized that "selective paste" works as expected when I compress the history stack of the original photo first.

HansBull commented 6 months ago

For me, selective copy is essentiallly broken in current master. Selective copy -> select all -> paste with overwrite (even with images with a clean history) -> garbled image as in s7habo's screenshot.

TurboGit commented 6 months ago

For me, selective copy is essentiallly broken in current master. Selective copy -> select all -> paste with overwrite (even with images with a clean history) -> garbled image as in s7habo's screenshot.

Can you please provide a step by step reproducer as all is fine on my case? TIA.

What is important:

Also screenshot would help... As long as I cannot reproduce there is no chance it will get fixed.

TurboGit commented 6 months ago

Strange. I have just recompiled the darktable and the problem is still there..

Ok, I've missed the video I can reproduce this issue... Yet I'm not sure if we can fix that. I'll need to think about this.

For the record if you do not select the one of the Exposure all is ok.

jenshannoschwalm commented 6 months ago

Exposure is special because of the proxy. Maybe we have to check for that somehow.

TurboGit commented 6 months ago

No this is because the copy/paste only handle the last change in history for a given module. Here the copy-part let you copy the two instances of exposure, and this is pasted as if there was multiple instance of the module. I have a plan to handle this, but I'm not sure how easy it is...

HansBull commented 6 months ago

Seems indeed to be fixed. Merci beaucoup!