search

darktable-org / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
9.52k stars 1.13k forks source link

Module 'crop and rotate' has insane data so it is bypassed for now #17416

Open orthorhombic opened 1 week ago

orthorhombic commented 1 week ago

Describe the bug

When viewing files that were imported using Lightroom-format XMP files in the darkroom tab, this causes the module 'crop and rotate has insane data so it is bypassed for now" error to come up and in some cases switches to an incorrect crop after initially displaying the correct crop. While I see this error in 4.8.1, this seems to be resolved on reverting to 4.8.0. Specifically, it doesn't seem to matter whether the files were imported in either version.

Understanding that this module is deprecated and probably expected to be a bit buggy, is there a better way to programmatically go from the crop parameters in an old XMP file to the new modules that replaced it so this error doesn't pop up? Manually switching modules is not feasible since I have many thousands of files.

   crs:HasCrop="True"
   crs:CropLeft="0.0"
   crs:CropTop="0.0058287795992714025"
   crs:CropRight="0.9990272373540856"
   crs:CropBottom="0.990528233151184"
   crs:CropAngle="0"

Specifically I found reference to this error in the following two files: https://github.com/darktable-org/darktable/blob/8395386b5bb0fcb06aa24e6500d7a19619b56d48/src/iop/ashift.c#L1217-L1222 https://github.com/darktable-org/darktable/blob/8395386b5bb0fcb06aa24e6500d7a19619b56d48/src/iop/clipping.c#L922-L926

Steps to reproduce

  1. Import a series of CR3 files with crop information in an xmp sidecar (FILENAME.CR3 with FILENAME.xmp). See example xmp below.
  2. Open each file in the darkroom tab where it will then notify you that the crop and rotate information is being imported.
  3. Click on one of the imported files with a crop set to receive the error message.

Expected behavior

darktable should have sane crop/rotate parameters or at least provide more information on what the cause is.

Logfile | Screenshot | Screencast

No obvious errors in the logs (run with flatpak run org.darktable.Darktable -d common)

    19.5887 pipe cache check              [full]                                  64 lines (important=5, used=3). Freed 828MB. Using using 96MB, limit=1503MB
    19.5888 pipe starting             CL0 [full]                                  (   0/   0) 1763x1193 scale=0.2211 --> (   0/   0) 1763x1193 scale=0.2211 ID=25646, nvidiacudanvidiartx2000adagenerationlaptopgpu
    19.5888 cache HIT                     [full]           gamma                  IOP_CS_RGB, hash=2b28497995a94a85
    19.5888 pipe data: from cache         [full]           gamma                  (   0/   0) 1763x1193 scale=0.2211
    19.5897 cache report                  [full]                                  64 lines (important=5, used=3, invalid=0). Using 96MB, limit=1503MB. Hits/run=0.50. Hits/test=0.071
    19.5897 pipe finished             CL0 [full]                                  (   0/   0) 1763x1193 scale=0.2211 --> (   0/   0) 1763x1193 scale=0.2211 ID=25646

    19.6336 [rawspeed_open] extensions list to ignore: `cr3'
    19.6336 [libraw_open] extensions whitelist: `cr3'
    19.7795 [dt_iop_reload_defaults] defaults reloaded for filmicrgb
    19.7796 [dt_iop_reload_defaults] defaults reloaded for basecurve
    19.7797 [dt_iop_reload_defaults] defaults reloaded for colorequal
    19.7797 [dt_iop_reload_defaults] defaults reloaded for colormapping
    19.7798 changed CAT for channelmixerrgb from (nil) to 0x5874e67de5d0
    19.7798 [dt_iop_reload_defaults] defaults reloaded for channelmixerrgb
    19.7802 [dt_iop_reload_defaults] defaults reloaded for colorin
    19.7802 [dt_iop_reload_defaults] defaults reloaded for crop
    19.7802 [dt_iop_reload_defaults] defaults reloaded for exposure
    19.7802 [dt_iop_reload_defaults] defaults reloaded for retouch
    19.7802 [dt_iop_reload_defaults] defaults reloaded for clipping
    19.7803 [dt_iop_reload_defaults] defaults reloaded for overlay
    19.7803 [dt_iop_reload_defaults] defaults reloaded for flip
    19.7803 [dt_iop_reload_defaults] defaults reloaded for ashift
    19.7803 [dt_iop_reload_defaults] defaults reloaded for cacorrectrgb
    19.7809 [dt_iop_reload_defaults] defaults reloaded for lens
    19.7809 [dt_iop_reload_defaults] defaults reloaded for rotatepixels
    19.7810 [dt_iop_reload_defaults] defaults reloaded for denoiseprofile
    19.7810 [dt_iop_reload_defaults] defaults reloaded for demosaic
    19.7810 [dt_iop_reload_defaults] defaults reloaded for rawdenoise
    19.7810 [dt_iop_reload_defaults] defaults reloaded for hotpixels
    19.7810 [dt_iop_reload_defaults] defaults reloaded for cacorrect
    19.7810 [dt_iop_reload_defaults] defaults reloaded for highlights
    19.7811 [dt_iop_reload_defaults] scene=YES, modern=YES, CAT=NO. D65 2.156 1.000 1.644, AS-SHOT 1.777 1.000 2.004
    19.7812 [dt_iop_reload_defaults] defaults reloaded for temperature
    19.7812 [dt_iop_reload_defaults] defaults reloaded for invert
    19.7812 [dt_iop_reload_defaults] defaults reloaded for rawprepare
    19.7852 [dt_dev_read_history_ext] temporary history deleted
    19.7852 [dt_iop_reload_defaults] defaults reloaded for filmicrgb
    19.7853 [dt_iop_reload_defaults] defaults reloaded for basecurve
    19.7853 [dt_iop_reload_defaults] defaults reloaded for colorequal
    19.7853 [dt_iop_reload_defaults] defaults reloaded for colormapping
    19.7854 [dt_iop_reload_defaults] defaults reloaded for channelmixerrgb
    19.7857 [dt_iop_reload_defaults] defaults reloaded for colorin
    19.7857 [dt_iop_reload_defaults] defaults reloaded for crop
    19.7857 [dt_iop_reload_defaults] defaults reloaded for exposure
    19.7857 [dt_iop_reload_defaults] defaults reloaded for retouch
    19.7857 [dt_iop_reload_defaults] defaults reloaded for clipping
    19.7857 [dt_iop_reload_defaults] defaults reloaded for overlay
    19.7857 [dt_iop_reload_defaults] defaults reloaded for flip
    19.7858 [dt_iop_reload_defaults] defaults reloaded for ashift
    19.7858 [dt_iop_reload_defaults] defaults reloaded for cacorrectrgb
    19.7863 [dt_iop_reload_defaults] defaults reloaded for lens
    19.7863 [dt_iop_reload_defaults] defaults reloaded for rotatepixels
    19.7864 [dt_iop_reload_defaults] defaults reloaded for denoiseprofile
    19.7864 [dt_iop_reload_defaults] defaults reloaded for demosaic
    19.7864 [dt_iop_reload_defaults] defaults reloaded for rawdenoise
    19.7864 [dt_iop_reload_defaults] defaults reloaded for hotpixels
    19.7864 [dt_iop_reload_defaults] defaults reloaded for cacorrect
    19.7864 [dt_iop_reload_defaults] defaults reloaded for highlights
    19.7864 [dt_iop_reload_defaults] scene=YES, modern=YES, CAT=NO. D65 2.156 1.000 1.644, AS-SHOT 1.777 1.000 2.004
    19.7866 [dt_iop_reload_defaults] defaults reloaded for temperature
    19.7866 [dt_iop_reload_defaults] defaults reloaded for invert
    19.7866 [dt_iop_reload_defaults] defaults reloaded for rawprepare
    19.7885 [dt_dev_read_history_ext] temporary history initialised with default params and presets
    19.7885 [dt_dev_read_history_ext] temporary history merged with image history
    19.7885 [history] successfully loaded module rawprepare from history
            blendop v. 13:  version ok  params ok
            params v. 2:    version ok  params ok
    19.7885 [history] successfully loaded module demosaic from history
            blendop v. 13:  version ok  params ok
            params v. 4:    version ok  params ok
    19.7885 [history] successfully loaded module colorin from history
            blendop v. 13:  version ok  params ok
            params v. 7:    version ok  params ok
    19.7885 [history] successfully loaded module colorout from history
            blendop v. 13:  version ok  params ok
            params v. 5:    version ok  params ok
    19.7886 [history] successfully loaded module gamma from history
            blendop v. 13:  version ok  params ok
            params v. 1:    version ok  params ok
    19.7886 [history] successfully loaded module temperature from history
            blendop v. 13:  version ok  params ok
            params v. 4:    version ok  params ok
    19.7886 [history] successfully loaded module highlights from history
            blendop v. 13:  version ok  params ok
            params v. 4:    version ok  params ok
    19.7886 [history] successfully loaded module channelmixerrgb from history
            blendop v. 13:  version ok  params ok
            params v. 3:    version ok  params ok
    19.7886 [history] successfully loaded module exposure from history
            blendop v. 13:  version ok  params ok
            params v. 6:    version ok  params ok
    19.7886 [history] successfully loaded module filmicrgb from history
            blendop v. 13:  version ok  params ok
            params v. 6:    version ok  params ok
    19.7886 [history] successfully loaded module flip from history
            blendop v. 13:  version ok  params ok
            params v. 2:    version ok  params ok
    19.7886 [history] successfully loaded module clipping from history
            blendop v. 13:  version ok  params ok
            params v. 5:    version ok  params ok
    19.7886 [history] successfully loaded module flip from history
            blendop v. 13:  version ok  params ok
            params v. 2:    version ok  params ok
    19.7902 used preset                                    temperature            preset='as shot to reference': D65 2.156 1.000 1.644, AS-SHOT 1.777 1.000 2.004
    19.8236 safety check                  [full]           clipping               (-385565952/22644)    0x   0 scale=-nan --> (   0/   0)    0x   0 scale=-nan 
    19.8263 pipe state changing           [full]                                  synch all, pipe remove
    19.8263 synch all module defaults     [full]                                  
    19.8665 synch all module history      [full]                                  
    19.8665 dt_dev_pixelpipe_synch        [full]           rawprepare             enabled  order= 1, piece hash=e7214a4bc7c48831, 
    19.8665 dt_dev_pixelpipe_synch        [full]           demosaic               enabled  order= 8, piece hash=b0702bc252a94bd2, 
    19.8665 dt_dev_pixelpipe_synch        [full]           colorin                enabled  order=32, piece hash=7563a39ceae1e96a, 
    19.8708 dt_dev_pixelpipe_synch        [full]           colorout               enabled  order=82, piece hash=8e5a0f73242a7524, 
    19.8708 dt_dev_pixelpipe_synch        [full]           gamma                  enabled  order=90, piece hash=1ae2f37bb34a05, 
    19.8708 dt_dev_pixelpipe_synch        [full]           temperature            enabled  order= 3, piece hash=7a021858362f03fd, 
    19.8709 dt_dev_pixelpipe_synch        [full]           highlights             enabled  order= 4, piece hash=26abe6488bb0049c, 
    19.8709 dt_dev_pixelpipe_synch        [full]           channelmixerrgb        enabled  order=33, piece hash=ea4c0920920ce984, 
    19.8709 dt_dev_pixelpipe_synch        [full]           exposure               enabled  order=24, piece hash=ee4f97460e9b04c9, 
    19.8709 dt_dev_pixelpipe_synch        [full]           filmicrgb              enabled  order=58, piece hash=b19e2a91a1628764, 
    19.8709 dt_dev_pixelpipe_synch        [full]           flip                   disabled order=17, piece hash=0, 
    19.8709 dt_dev_pixelpipe_synch        [full]           clipping               enabled  order=20, piece hash=4447a6181524c01c, 
    19.8709 dt_dev_pixelpipe_synch        [full]           flip                   enabled  order=17, piece hash=17c5e2847, 
    19.8709 synch all modules done        [full]                                  defaults 0.0402s, history 0.0044s
    19.8734 synch all module defaults     [full]                                  
    19.9028 synch all module history      [full]                                  
    19.9028 dt_dev_pixelpipe_synch        [full]           rawprepare             enabled  order= 1, piece hash=e7214a4bc7c48831, 
    19.9028 dt_dev_pixelpipe_synch        [full]           demosaic               enabled  order= 8, piece hash=b0702bc252a94bd2, 
    19.9028 dt_dev_pixelpipe_synch        [full]           colorin                enabled  order=32, piece hash=7563a39ceae1e96a, 
    19.9066 dt_dev_pixelpipe_synch        [full]           colorout               enabled  order=82, piece hash=8e5a0f73242a7524, 
    19.9066 dt_dev_pixelpipe_synch        [full]           gamma                  enabled  order=90, piece hash=1ae2f37bb34a05, 
    19.9066 dt_dev_pixelpipe_synch        [full]           temperature            enabled  order= 3, piece hash=7a021858362f03fd, 
    19.9066 dt_dev_pixelpipe_synch        [full]           highlights             enabled  order= 4, piece hash=26abe6488bb0049c, 
    19.9066 dt_dev_pixelpipe_synch        [full]           channelmixerrgb        enabled  order=33, piece hash=ea4c0920920ce984, 
    19.9066 dt_dev_pixelpipe_synch        [full]           exposure               enabled  order=24, piece hash=ee4f97460e9b04c9, 
    19.9066 dt_dev_pixelpipe_synch        [full]           filmicrgb              enabled  order=58, piece hash=b19e2a91a1628764, 
    19.9066 dt_dev_pixelpipe_synch        [full]           flip                   disabled order=17, piece hash=0, 
    19.9066 dt_dev_pixelpipe_synch        [full]           clipping               enabled  order=20, piece hash=4447a6181524c01c, 
    19.9066 dt_dev_pixelpipe_synch        [full]           flip                   enabled  order=17, piece hash=17c5e2847, 
    19.9067 synch all modules done        [full]                                  defaults 0.0294s, history 0.0039s
    19.9067 modify roi OUT                [full]           rawprepare             (   0/   0) 8352x5586 scale=1.0000 --> (   0/   0) 8191x5463 scale=1.0000 ID=25621
    19.9101 pipe cache check              [full]                                  64 lines (important=5, used=0). Freed 96MB. Using using 0MB, limit=1503MB
    19.9101 pipe starting             CL0 [full]                                  (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 1788x1193 scale=0.2184 ID=25621, nvidiacudanvidiartx2000adagenerationlaptopgpu
    19.9101 enable fast pipe              [full/fast]      clipping               
    19.9101 modify roi IN                 [full/fast]      demosaic               (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 8187x5463 scale=1.0000 ID=25621
    19.9101 modify roi IN                 [full/fast]      highlights             (   0/   0) 8187x5463 scale=1.0000 --> (   0/   0) 8191x5463 scale=1.0000 ID=25621
    19.9101 modify roi IN                 [full/fast]      rawprepare             (   0/   0) 8191x5463 scale=1.0000 --> (   0/   0) 8352x5586 scale=1.0000 ID=25621
    19.9101 pipe data: full               [full/fast]                             (   0/   0) 8352x5586 scale=1.0000 --> (   0/   0) 8352x5586 scale=1.0000 
    19.9197 process                   CL0 [full/fast]      rawprepare             (   0/   0) 8352x5586 scale=1.0000 --> (   0/   0) 8191x5463 scale=1.0000   1 IOP_CS_RAW
    19.9216 process                   CL0 [full/fast]      temperature            (   0/   0) 8191x5463 scale=1.0000 --> (   0/   0) 8191x5463 scale=1.0000   3 IOP_CS_RAW
    19.9249 process                   CL0 [full/fast]      highlights             (   0/   0) 8191x5463 scale=1.0000 --> (   0/   0) 8187x5463 scale=1.0000   4 IOP_CS_RAW
    19.9305 opposed chroma            CL0 [full/fast]      highlights             (   0/   0) 8191x5463 scale=1.0000 --> (   0/   0) 8187x5463 scale=1.0000 red: 0.0000, green: 0.0000, blue: 0.0000 for hash=b06aeeb74e7189b7, unclipped
    19.9332 process                   CL0 [full/fast]      demosaic               (   0/   0) 8187x5463 scale=1.0000 --> (   0/   0) 1788x1193 scale=0.2184   8 IOP_CS_RAW -> IOP_CS_RGB
    19.9885 clip_and_zoom_roi         CL0 [full/fast]      demosaic               (   0/   0) 8187x5463 scale=1.0000 --> (   0/   0) 1788x1193 scale=0.2184 
    20.0087 process                   CL0 [full/fast]      flip                   (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 1788x1193 scale=0.2184  17 IOP_CS_RGB
    20.0129 process                   CL0 [full/fast]      clipping               (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 1788x1193 scale=0.2184  20 IOP_CS_RGB
    20.0281 copy CL data to host      CL0 [full/fast]      clipping               (   0/   0) 1788x1193 scale=0.2184
    20.0283 importance hints          CL0 [full/fast]      clipping               (   0/   0) 1788x1193 scale=0.2184 focus cldata
    20.0286 process                   CL0 [full/fast]      exposure               (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 1788x1193 scale=0.2184  24 IOP_CS_RGB
    20.0296 process                   CL0 [full/fast]      colorin                (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 1788x1193 scale=0.2184  32 IOP_CS_RGB -> IOP_CS_LAB
    20.0297 matrix conversion         CL0 [full/fast]      colorin                (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 1788x1193 scale=0.2184 `standard color matrix', corrected by: 1.213 1.000 0.821
    20.0311 transform colorspace      CL0 [full/fast]      channelmixerrgb        (   0/   0) 1788x1193 scale=0.2184 IOP_CS_LAB -> IOP_CS_RGB `linear Rec2020 RGB'
    20.0335 process                   CL0 [full/fast]      channelmixerrgb        (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 1788x1193 scale=0.2184  33 IOP_CS_RGB
    20.0343 process                   CL0 [full/fast]      filmicrgb              (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 1788x1193 scale=0.2184  58 IOP_CS_RGB
    20.0368 transform colorspace      CL0 [full/fast]      colorout               (   0/   0) 1788x1193 scale=0.2184 IOP_CS_RGB -> IOP_CS_LAB `linear Rec2020 RGB'
    20.0390 process                   CL0 [full/fast]      colorout               (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 1788x1193 scale=0.2184  82 IOP_CS_LAB -> IOP_CS_RGB
    20.0524 copy CL data to host      CL0 [full/fast]      colorout               (   0/   0) 1788x1193 scale=0.2184
    20.0525 importance hints          CL0 [full/fast]      colorout               (   0/   0) 1788x1193 scale=0.2184 cldata
    20.0650 process                   CPU [full/fast]      gamma                  (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 1788x1193 scale=0.2184  90 IOP_CS_RGB
    20.0714 cache report                  [full/fast]                             64 lines (important=8, used=12, invalid=8). Using 805MB, limit=1503MB. Hits/run=0.40. Hits/test=0.049
    20.0715 pipe finished             CL0 [full/fast]                             (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 1788x1193 scale=0.2184 ID=25621

    20.0717 changed CAT for channelmixerrgb from (nil) to 0x5874e67de5d0
    20.0751 used preset                                    temperature            preset='as shot to reference': D65 2.156 1.000 1.644, AS-SHOT 1.777 1.000 2.004
    20.0829 pipe state changing           [full/fast]                             
    20.0830 modify roi OUT                [full/fast]      rawprepare             (   0/   0) 8352x5586 scale=1.0000 --> (   0/   0) 8191x5463 scale=1.0000 ID=25621
    20.0832 pipe cache check              [full/fast]                             64 lines (important=8, used=4). Freed 675MB. Using using 130MB, limit=1503MB
    20.0832 pipe starting             CL0 [full/fast]                             (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 1788x1193 scale=0.2184 ID=25621, nvidiacudanvidiartx2000adagenerationlaptopgpu
    20.0832 cache HIT                     [full/fast]      gamma                  IOP_CS_RGB, hash=f271b767ea71cb78
    20.0832 pipe data: from cache         [full/fast]      gamma                  (   0/   0) 1788x1193 scale=0.2184
    20.0908 cache report                  [full/fast]                             64 lines (important=8, used=4, invalid=0). Using 130MB, limit=1503MB. Hits/run=0.50. Hits/test=0.071
    20.0908 pipe finished             CL0 [full/fast]                             (   0/   0) 1788x1193 scale=0.2184 --> (   0/   0) 1788x1193 scale=0.2184 ID=25621

    20.1317 pipe state changing           [preview]                               synch all, pipe remove
    20.1318 synch all module defaults     [preview]                               
    20.1643 synch all module history      [preview]                               
    20.1643 dt_dev_pixelpipe_synch        [preview]        rawprepare             enabled  order= 1, piece hash=e7214a4bc7c48831, 
    20.1643 dt_dev_pixelpipe_synch        [preview]        demosaic               enabled  order= 8, piece hash=b0702bc252a94bd2, 
    20.1644 dt_dev_pixelpipe_synch        [preview]        colorin                enabled  order=32, piece hash=7563a39ceae1e96a, 
    20.1679 dt_dev_pixelpipe_synch        [preview]        colorout               enabled  order=82, piece hash=8e5a0f73242a7524, 
    20.1679 dt_dev_pixelpipe_synch        [preview]        gamma                  enabled  order=90, piece hash=1ae2f37bb34a05, 
    20.1679 dt_dev_pixelpipe_synch        [preview]        temperature            enabled  order= 3, piece hash=7a021858362f03fd, 
    20.1679 dt_dev_pixelpipe_synch        [preview]        highlights             enabled  order= 4, piece hash=26abe6488bb0049c, 
    20.1680 dt_dev_pixelpipe_synch        [preview]        channelmixerrgb        enabled  order=33, piece hash=ea4c0920920ce984, 
    20.1680 dt_dev_pixelpipe_synch        [preview]        exposure               enabled  order=24, piece hash=ee4f97460e9b04c9, 
    20.1680 dt_dev_pixelpipe_synch        [preview]        filmicrgb              enabled  order=58, piece hash=b19e2a91a1628764, 
    20.1680 dt_dev_pixelpipe_synch        [preview]        flip                   disabled order=17, piece hash=0, 
    20.1680 dt_dev_pixelpipe_synch        [preview]        clipping               enabled  order=20, piece hash=4447a6181524c01c, 
    20.1680 dt_dev_pixelpipe_synch        [preview]        flip                   enabled  order=17, piece hash=17c5e2847, 
    20.1680 synch all modules done        [preview]                               defaults 0.0326s, history 0.0037s
    20.1708 synch all module defaults     [preview]                               
    20.2018 synch all module history      [preview]                               
    20.2018 dt_dev_pixelpipe_synch        [preview]        rawprepare             enabled  order= 1, piece hash=e7214a4bc7c48831, 
    20.2018 dt_dev_pixelpipe_synch        [preview]        demosaic               enabled  order= 8, piece hash=b0702bc252a94bd2, 
    20.2019 dt_dev_pixelpipe_synch        [preview]        colorin                enabled  order=32, piece hash=7563a39ceae1e96a, 
    20.2056 dt_dev_pixelpipe_synch        [preview]        colorout               enabled  order=82, piece hash=8e5a0f73242a7524, 
    20.2057 dt_dev_pixelpipe_synch        [preview]        gamma                  enabled  order=90, piece hash=1ae2f37bb34a05, 
    20.2057 dt_dev_pixelpipe_synch        [preview]        temperature            enabled  order= 3, piece hash=7a021858362f03fd, 
    20.2057 dt_dev_pixelpipe_synch        [preview]        highlights             enabled  order= 4, piece hash=26abe6488bb0049c, 
    20.2057 dt_dev_pixelpipe_synch        [preview]        channelmixerrgb        enabled  order=33, piece hash=ea4c0920920ce984, 
    20.2057 dt_dev_pixelpipe_synch        [preview]        exposure               enabled  order=24, piece hash=ee4f97460e9b04c9, 
    20.2057 dt_dev_pixelpipe_synch        [preview]        filmicrgb              enabled  order=58, piece hash=b19e2a91a1628764, 
    20.2057 dt_dev_pixelpipe_synch        [preview]        flip                   disabled order=17, piece hash=0, 
    20.2057 dt_dev_pixelpipe_synch        [preview]        clipping               enabled  order=20, piece hash=4447a6181524c01c, 
    20.2057 dt_dev_pixelpipe_synch        [preview]        flip                   enabled  order=17, piece hash=17c5e2847, 
    20.2057 synch all modules done        [preview]                               defaults 0.0310s, history 0.0039s
    20.2057 modify roi OUT                [preview]        rawprepare             (   0/   0) 1345x 900 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000 ID=25621
    20.2093 pipe cache check              [preview]                               12 lines (important=2, used=0). Freed 172MB. Using using 0MB, limit=0MB
    20.2093 pipe starting             CL0 [preview]                               (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000 ID=25621, nvidiacudanvidiartx2000adagenerationlaptopgpu
    20.2093 enable fast pipe              [preview/fast]   clipping               
    20.2093 modify roi IN                 [preview/fast]   rawprepare             (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1345x 900 scale=1.0000 ID=25621
    20.2093 pipe data: full               [preview/fast]                          (   0/   0) 1345x 900 scale=1.0000 --> (   0/   0) 1345x 900 scale=1.0000 
    20.2102 process                   CL0 [preview/fast]   rawprepare             (   0/   0) 1345x 900 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000   1 IOP_CS_RAW
    20.2110 process                   CL0 [preview/fast]   temperature            (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000   3 IOP_CS_RAW
    20.2116 process                   CL0 [preview/fast]   highlights             (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000   4 IOP_CS_RAW
    20.2120 opposed chroma            CL0 [preview/fast]   highlights             (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000 red: 0.0000, green: 0.0000, blue: 0.0000 for hash=b06aeeb74e7189b7, unclipped
    20.2126 process                   CL0 [preview/fast]   demosaic               (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000   8 IOP_CS_RAW -> IOP_CS_RGB
    20.2155 process                   CL0 [preview/fast]   flip                   (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000  17 IOP_CS_RGB
    20.2163 process                   CL0 [preview/fast]   clipping               (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000  20 IOP_CS_RGB
    20.2296 copy CL data to host      CL0 [preview/fast]   clipping               (   0/   0) 1319x 880 scale=1.0000
    20.2298 importance hints          CL0 [preview/fast]   clipping               (   0/   0) 1319x 880 scale=1.0000 focus cldata
    20.2301 process                   CL0 [preview/fast]   exposure               (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000  24 IOP_CS_RGB
    20.2308 process                   CL0 [preview/fast]   colorin                (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000  32 IOP_CS_RGB -> IOP_CS_LAB
    20.2308 matrix conversion         CL0 [preview/fast]   colorin                (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000 `standard color matrix', corrected by: 1.213 1.000 0.821
    20.2325 transform colorspace      CL0 [preview/fast]   channelmixerrgb        (   0/   0) 1319x 880 scale=1.0000 IOP_CS_LAB -> IOP_CS_RGB `linear Rec2020 RGB'
    20.2355 process                   CL0 [preview/fast]   channelmixerrgb        (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000  33 IOP_CS_RGB
    20.2356 changed CAT for channelmixerrgb from (nil) to 0x5874e67de5d0
    20.2366 process                   CL0 [preview/fast]   filmicrgb              (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000  58 IOP_CS_RGB
    20.2395 transform colorspace      CL0 [preview/fast]   colorout               (   0/   0) 1319x 880 scale=1.0000 IOP_CS_RGB -> IOP_CS_LAB `linear Rec2020 RGB'
    20.2416 process                   CL0 [preview/fast]   colorout               (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000  82 IOP_CS_LAB -> IOP_CS_RGB
    20.2496 copy CL data to host      CL0 [preview/fast]   colorout               (   0/   0) 1319x 880 scale=1.0000
    20.2497 importance hints          CL0 [preview/fast]   colorout               (   0/   0) 1319x 880 scale=1.0000 cldata
    20.2570 process                   CPU [preview/fast]   gamma                  (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000  90 IOP_CS_RGB
    20.2615 dt_ioppr_transform_image_colorspace_rgb `system display profile' -> `sRGB' [final histogram]
    20.2659 cache report                  [preview/fast]                          12 lines (important=3, used=8, invalid=4). Using 142MB, limit=0MB. Hits/run=0.00. Hits/test=0.000
    20.2659 pipe finished             CL0 [preview/fast]                          (   0/   0) 1319x 880 scale=1.0000 --> (   0/   0) 1319x 880 scale=1.0000 ID=25621

    20.2660 modify roi OUT                [full/fast]      rawprepare             (   0/   0) 8352x5586 scale=1.0000 --> (   0/   0) 8191x5463 scale=1.0000 ID=25621
    20.2661 chroma data                                    channelmixerrgb        D65=YES.  NOW 1.777 1.000 2.004, D65 2.156 1.000 1.644, AS-SHOT 1.777 1.000 2.004 File `_JK_1213.CR3' ID=25621

Commit

No response

Where did you obtain darktable from?

flatpak

darktable version

4.8.1

What OS are you using?

Linux

What is the version of your OS?

Ubuntu 22.04

Describe your system?

Darktable installed via flatpak Kernel: 6.8.0-40-generic RAM: 96gb Graphics NVidia A2000 8gb

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

A2000 Driver Version: 550.107.02 CUDA Version: 12.4

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

Below is an example of a full XMP sidecar that I used with CR3 files from a Canon R5 I was importing and received errors with:

<?xpacket begin="" id="W5M0MpCehiHzreSzNTczkc9d"?>
<x:xmpmeta xmlns:x="adobe:ns:meta/" x:xmptk="XMP Core 4.4.0-Exiv2">
 <rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#">
  <rdf:Description rdf:about=""
    xmlns:crs="http://ns.adobe.com/camera-raw-settings/1.0/"
    xmlns:tiff="http://ns.adobe.com/tiff/1.0/"
    xmlns:xmp="http://ns.adobe.com/xap/1.0/"
   crs:HasCrop="True"
   crs:CropLeft="0.0"
   crs:CropTop="0.0058287795992714025"
   crs:CropRight="0.9990272373540856"
   crs:CropBottom="0.990528233151184"
   crs:CropAngle="0"
   tiff:ImageWidth="8224"
   tiff:ImageLength="5490"
   tiff:Orientation="2"
   xmp:Rating="0"/>
 </rdf:RDF>
</x:xmpmeta>
<?xpacket end="w"?>
elstoc commented 1 week ago

If we're intent on maintaining the LR import process, we should alter it to use non-deprecated modules.

orthorhombic commented 1 week ago

Regardless of whether the LR import process is deprecated or not, is there a pathway to batch move photos from this deprecated module to the new modules?

elstoc commented 1 week ago

no there isn't