search

darktrojan / openwith

Open With add-on for Firefox
https://addons.mozilla.org/addon/open-with/
412 stars 71 forks source link

No icons display for all browsers except Edge #115

Open trulycool opened 8 years ago

trulycool commented 8 years ago

I'm on Windows 10, Firefox, 48.02. I have several different browsers installed, and Open With finds them all fine, but only displays an icon for Edge.

This is such a great extension, but the lack of icons, or the ability to at least set them manually is really hampering it's usefulness.

It's OK when using the drop down menu, but ideally I'd have the buttons in the toolbar, available as a single click, and they are useless there as blanks. Well, not exactly useless as they display tooltips, but much less convenient than one would like.

2016-09-10_12-35-04

2016-09-10_12-35-45

trulycool commented 8 years ago

Started digging into this a bit more, and found the wiki with instructions for manually setting an icon via about:config.

However, manually setting an icon for an entry does not work either. Some part worked as the blank page icon disappeared, so I know I got the key syntax correct. However, I tried .png, and several different formats of .ico, as well as the *.exe, and all produced the same result. The blank page placeholder disappeared, the menu text moved over, but no icon shows...

openwith menu

openwith about-config

* Note * This is the version of the plugin I sent a pull request for, which is why the icon in the toolbar does have a transparent background, but the only change I made was to the toolbar icon, no code changes, and I tested in a stock version too, same results.

darktrojan commented 8 years ago

Have you tried disabling other addons and/or your theme to see if they are causing the problem?

Also, take out all the quotes from that preference value, turn the \s to /s and add another / before the C:.

trulycool commented 8 years ago

Yes, same result. I've just created an empty profile, Firefox 48.0.2, with only Open With installed (no other add-ons or themes...

Note this is a fresh install of Open With also, not the version which I updated the bg transparency of the toolbar icon (and created the pull request for).

-M

On 9/11/2016 9:23 PM, Geoff Lankow wrote:

Have you tried disabling other addons and/or your theme to see if they are causing the problem?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/darktrojan/openwith/issues/115#issuecomment-246218979, or mute the thread https://github.com/notifications/unsubscribe-auth/AAyI0vdc6DX_BDtBHmawy31CgFq4RqT4ks5qpKmvgaJpZM4J5w3H.

darktrojan commented 8 years ago

I was just looking on Bugzilla for more info and realised I've seen this before, but never found a solution: https://bugzilla.mozilla.org/show_bug.cgi?id=710123