search

darktrojan / openwith

Open With add-on for Firefox
https://addons.mozilla.org/addon/open-with/
412 stars 71 forks source link

fix open_with_mac.py Thunderbird on MacOS path. #290

Closed robcast closed 3 years ago

robcast commented 3 years ago

Fix for the different path for NativeMessagingHost for Thunderbird on MacOS.

I tested a fresh installation of Thunderbird 78.5.1 on MacOS (Big Sur) and it creates ~/Library/Mozilla and uses ~/Library/Mozilla/NativeMessagingHosts. It does not create or use ~/Library/Application Support/Thunderbird.

See also comments in #284.

I could add the ~/Library/Application Support/Thunderbird version to the script if you prefer to keep that version too.

greenflute commented 3 years ago

Thanks for the test :), my Thunderbird Installation goes way back to 10.6 Snow Leopard days, just too old. Maybe it is better to somehow detect the Thunderbird version, or try to figure out which directory the installed Thunderbird actually uses.

robcast commented 3 years ago

I think the existing test for the base directory should work. I will add the Application Support location to the patch if that location was used in the past.

I don't know of a better test for the right NativeMessagingHost directory.

darktrojan commented 3 years ago

Thanks for your patch! I've confused Github with it somehow, so closing this pull manually.