search

darpa-sail-on / sail-on-client

Client and Protcols for DARPA Sail On.
https://darpa-sail-on.github.io/sail-on-client/index.html
Other
2 stars 0 forks source link

Splitting Novelty Detector functions into different classes #25

Open as6520 opened 3 years ago

as6520 commented 3 years ago

In GitLab by @as6520 on Apr 23, 2020, 15:34

Currently Novelty Detector does feature extraction, novelty_detection and novelty_characterization. We can split this up into different classes with novelty detector doing only detection, novelty characterization only characterizing and a feature extractor for only extracting_features. This would make the components more swapable.

as6520 commented 3 years ago

In GitLab by @as6520 on Apr 23, 2020, 16:01

changed the description

as6520 commented 3 years ago

In GitLab by @rwgdrummer on Apr 29, 2020, 11:16

This is a good idea....

State of detection and characterization are often the same or pipelined...so how does that work with an instance management standpoint? Detection and Characterization can happen at the same time.

Some patterns: (1) Shared State Holder Pattern (2) Pipeline..detection into characterization (3) Multi-interface implementations...so the binding underneath can be the same instance can support both, in which case, only instantiate one. (4) ?

as6520 commented 3 years ago

In GitLab by @as6520 on Apr 29, 2020, 12:23

I had not thought about the instance management issue. Thanks for bringing it up.

You are correct that detection and characterization can happen at the same time which would make the it difficult for someone developing the algorithm to detect and characterize in different classes while sharing a common state.

Let me look into those patterns so that I can understand what those are. Thanks for suggesting them