search

darrenjennings / vue-autosuggest

🔍 Vue autosuggest component.
https://darrenjennings.github.io/vue-autosuggest
MIT License
621 stars 91 forks source link

fix(scroll) remove scrollTo to support IE/edge #104

Closed darrenjennings closed 5 years ago

darrenjennings commented 5 years ago

Fixes #40

codecov-io commented 5 years ago

Codecov Report

Merging #104 into master will not change coverage. The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   80.33%   80.33%           
=======================================
  Files           1        1           
  Lines         178      178           
  Branches       54       54           
=======================================
  Hits          143      143           
  Misses         11       11           
  Partials       24       24
Impacted Files Coverage Δ
src/Autosuggest.vue 80.33% <50%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9101626...3a2dd9e. Read the comment docs.

scottadamsmith commented 5 years ago

Just a heads up but this alone likely won’t fix IE11. I mentioned in a previous issue that two polyfills could be used to support IE11.

https://github.com/darrenjennings/vue-autosuggest/issues/80#issuecomment-442829596

darrenjennings commented 5 years ago

Thanks for the note @scottadamsmith. If you had time would be helpful to also confirm latest release doesn't have any errors. I used browserstack and didn't see any issues on edge/ie11 but not ruling it out.