darrenjennings / vue-autosuggest

🔍 Vue autosuggest component.
https://darrenjennings.github.io/vue-autosuggest
MIT License
621 stars 91 forks source link

fix(inputProps): make name configurable #39

Closed darrenjennings closed 6 years ago

darrenjennings commented 6 years ago

Fixes #37

What: Name is now configurable, where before it was always "q"

Why: When you create a form, the name attribute on your inputs are very important. Need to be configurable.

How: Add name to inputProps defaults so will default to "q", but can be overridden.

Checklist:

codecov[bot] commented 6 years ago

Codecov Report

Merging #39 into master will increase coverage by 0.09%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   84.04%   84.14%   +0.09%     
==========================================
  Files           1        1              
  Lines         163      164       +1     
  Branches       48       48              
==========================================
+ Hits          137      138       +1     
  Misses          8        8              
  Partials       18       18
Impacted Files Coverage Δ
src/Autosuggest.vue 84.14% <100%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c0d71d...40ded66. Read the comment docs.