search

darrenjennings / vue-autosuggest

🔍 Vue autosuggest component.
https://darrenjennings.github.io/vue-autosuggest
MIT License
621 stars 91 forks source link

Empty string passed to getElementById() on FireFox (Windows) #81

Closed ghost closed 5 years ago

ghost commented 5 years ago

I noticed a (or actually two) message in the console each time the input component is clicked. This however only happens in Firefox (latest) browser on Windows. Chrome and Safari (and even IE) are doing just fine. The message shown is "Empty string passed to getElementById()" and the source appears to be "iframe.html". Anyone else noticed this?

Steps to reproduce: 1) Open Firefox for Windows 2) Navigate to https://educents.github.io/vue-autosuggest/storybook/?selectedKind=Vue-Autosuggest&selectedStory=simplest&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel 3) Open the Console on the Developer Toolbar 4) Click in the input field and notice 2 warnings titled "Empty string passed to getElementById()"

Thanks for the awesome component, one of the few around that are well thought-out and designed, and has support for multiple result sets!

darrenjennings commented 5 years ago

@highstone thanks for the kind words. I am not seeing this error on firefox, but it sounds like a storybook specific error as vue-autosuggest does not use getElementById() in latest version, whereas storybook uses this method and embeds the component in an iframe. Let me know if you have any other insights into nature of error.

ghost commented 5 years ago

Well, eh no. I noticed it in a project we're using vue-autosuggest in. And to verify it wasn't the project setup I opened the storybook and was able to reproduce the issue there... It's not a high priority thing, I was just wondering what could be causing this or if anyone has noticed this behaviour before.

darrenjennings commented 5 years ago

🤔since I am unable to reproduce, another guess I have is that there is a browser extension you are using that is messing with click events. I've seen console errors from iframes in the past through extensions mucking with an app. If you can confirm that you are not using any firefox extensions then I am unsure where getElementById is coming from.

darrenjennings commented 5 years ago

Closing this due to inactivity and not being able to reproduce.