TST: portable forked process test

darshan-hpc / darshan

Darshan I/O characterization tool

Other

57 stars 28 forks source link

TST: portable forked process test #880

Closed tylerjereddy closed 1 year ago

tylerjereddy commented 1 year ago

Fixes #828

the forked process tests were failing locally with act -j test_runtime
use a more portable approach to retrieving the absolute path to the system Python executable (compared with assuming that python will do)

shanedsnyder commented 1 year ago

Notice that the other 2 test cases (test_h5oopen_h5py_roundtrip and test_runtime_heatmap_div_by_zero) reference python executable in the same way. Presumably those aren't tripping any errors because mpirun is invoking them, though I'm not sure I understand why?

Should those 2 be fixed as well?

tylerjereddy commented 1 year ago

Probably better to change those other tests as well, but I haven't seen executable evidence of a problem. I can circle back to it, probably low priority for the other two.

shanedsnyder commented 1 year ago

Sounds good. Probably not a big deal if they work in CI as well as with act, that covers all the use cases. I'll go ahead and approve, and leave to you to either update or go ahead and merge.