search

darshan-hpc / darshan

Darshan I/O characterization tool
Other
57 stars 28 forks source link

Fix HDF5 reference issue. #908

Closed yzanhua closed 1 year ago

yzanhua commented 1 year ago

According to HDF5 Doc, the identifier returned by H5Iget_file_id needs to be released using H5Fclose.

This fix darshan-hpc/darshan#906

shanedsnyder commented 1 year ago

Thanks a lot for investigating and fixing this @yzanhua !

I just had one small suggestion in the review, but your proposed fix makes sense. We were clearly forgetting to free up some HDF5 resources so will be good to fix that.

shanedsnyder commented 1 year ago

Never mind on the requested change, that was a misunderstanding on my part. I'll go ahead and merge this in. Thanks again!