search

dart-archive / dart2_fix

A tool to migrate API usage to Dart 2
https://pub.dartlang.org/packages/dart2_fix
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

dart2_fix hangs on directories with no dart files #36

Open leafpetersen opened 6 years ago

leafpetersen commented 6 years ago 
leafp-macbookpro:particledesigner leafp$ mkdir foo
leafp-macbookpro:particledesigner leafp$ ~/src/flutter/bin/flutter packages pub global run dart2_fix foo
Checking foo...
^C
leafp-macbookpro:particledesigner leafp$ touch foo/empty
leafp-macbookpro:particledesigner leafp$ ~/src/flutter/bin/flutter packages pub global run dart2_fix foo
Checking foo...
^C
leafp-macbookpro:particledesigner leafp$ touch foo/empty.dart
leafp-macbookpro:particledesigner leafp$ ~/src/flutter/bin/flutter packages pub global run dart2_fix foo
Checking foo...

Found 0 fixes in 2.0s.
devoncarew commented 6 years ago

Hmm, we likely get no 'starting analysis', 'stopping analysis' notifications from the analysis server here, given that there are no files to analyze.

bwilkerson commented 6 years ago

Yes, those notifications are only generated when there are files to analyze.