feat: reenable check for visibility modifiers

dart-archive / ts2dart

ts2dart TypeScript to Dart transpiler

Apache License 2.0

181 stars 62 forks source link

feat: reenable check for visibility modifiers #279

Closed harryterkelsen closed 9 years ago

harryterkelsen commented 9 years ago

Fixes #278

mprobst commented 9 years ago

LGTM, please merge.

harryterkelsen commented 9 years ago

Should I merge even if there are several hundred places in Angular that will become errors if this check is turned on?

mprobst commented 9 years ago

Yes, but that makes you responsible to fix those in Angular when you upgrade ts2dart :-)

harryterkelsen commented 9 years ago

I've already fixed all of the private fields without leading underscores. I would actually like to allow public fields with leading underscores since that is helpful for dart2js. What do you think?

mprobst commented 9 years ago

Merged as e288c35.

As discussed offline, let's make all those public fields leading with an underscore in angular private, as they should be.