search

dart-archive / ts2dart

ts2dart TypeScript to Dart transpiler
Apache License 2.0
181 stars 62 forks source link

Add ability to install globally and execute as command line app #372

Closed luisvt closed 8 years ago

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented 8 years ago

CLAs look good, thanks!

googlebot commented 8 years ago

CLAs look good, thanks!

mprobst commented 8 years ago

Thanks for the contribution!

I think the build failure might be a fluke (pub install something something), rerunning tests now to see if that's true. Let's see if it succeeds, otherwise this seems good to merge.

mprobst commented 8 years ago

I see, I think you might have to just bump the version of "test" in this file to 0.12.15+3: https://github.com/angular/ts2dart/blob/master/test/e2e/pubspec.yaml

Sorry for the yak shaving required here, this project has been somewhat less than active for a while, so bit rot creeps in.

luisvt commented 8 years ago

Thanks, I will do it

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented 8 years ago

CLAs look good, thanks!

googlebot commented 8 years ago

CLAs look good, thanks!

mprobst commented 8 years ago

Thanks, merged!

mprobst commented 8 years ago

This has been released as 0.9.11.