dart-backend / angel

A polished, production-ready backend framework in Dart for the VM, AOT, and Flutter.
https://github.com/dukefirehawk/angel
BSD 3-Clause "New" or "Revised" License
174 stars 25 forks source link

Pb with Part Files Generations #171

Open Philac35 opened 1 month ago

Philac35 commented 1 month ago

Hello, When we generate models with Angel3_orm_generator, it generates positionals parameters and nameds parameters. It should be interesting to have the choice. Thank you

dukefirehawk commented 1 month ago

Is there a particular use case for the need of having it as an options? Changing the code to support both will introduce a lot of complexity. Unless there is a compelling reason for it, prefer not to go down this path. Besides, there are a couple issues that would need to be addressed first.

Philac35 commented 1 month ago

Here, both type of parameters are generated. We need to delete one to get functionals classes. It seems that named parameters are privileged in Angel 3 . We could keep it. Perhaps someone need positionals parameters, that 's why i talked about the creation of an optional solution. In all cases, we should not have to delete half of parameters for each models. Thank you

dukefirehawk commented 1 month ago

There is no need to modify the generated classes. Could you share your models that are having this problem?

Philac35 commented 3 weeks ago

I understood why i got the pb. Except of jsonb set in generated files that suit for postgre whereas mysql need json, i successed to generate tables.