Open mosuem opened 1 month ago
Should this package not be auto-published? @devoncarew
Should this package not be auto-published? @devoncarew
I think it's fine to auto-publish. We will want to upgrade our publishing automation a bit; with many packages living in a repo, we'll want to have some precision about which commits we publish from (i.e., not just the head commit). I'll open an issue for that.
I think it's fine to auto-publish. We will want to upgrade our publishing automation a bit; with many packages living in a repo, we'll want to have some precision about which commits we publish from (i.e., not just the head commit). I'll open an issue for that.
I am asking because the publish workflow is failing because of the dependency on a pre-release SDK version, and I don't know how SDK versioning is handled with package:lints
.
I am asking because the publish workflow is failing because of the dependency on a pre-release SDK version, and I don't know how SDK versioning is handled with
package:lints
.
Ah, I see;
Package validation found the following potential issue: Packages with an SDK constraint on a pre-release of the Dart SDK should themselves be published as a pre-release version. If this package needs Dart version 3.6.0-0, consider publishing the package as a pre-release instead.
And once this package is in a monorepo, every PR will need to apply a label to ignore failures from the publishing bot. That's a bit annoying.
We could either solve that - allow per-package configuration of publishing validation - or delay adding this package to the monorepo until after the next stable sdk release. We don't typically need to depend on a pre-release sdk for package:lints.
[x] Move and fix workflow files, labeler.yaml, and badges in the README.md
[x] Rev the version of the package, so that pub.dev points to the correct site
[x] Add a line to the changelog:
Move to
dart-lang/core
monorepo.[x] Add the package to the top-level readme of the monorepo:
[ ] Important! Merge the PR with 'Create a merge commit' (enabling then disabling the
Allow merge commits
admin setting)[ ] Add the lints project to this repo
[ ] Update the auto-publishing settings on https://pub.dev/packages/lints/admin
[x] Add the following text to https://github.com/dart-lang/lints/:'
git tag --list 'lints*' | xargs git push origin
dart run pkgs/repo_manage/bin/report.dart transfer-issues --source-repo dart-lang/lints --target-repo dart-lang/core --add-label package:lints --apply-changes
Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.