dart-lang / core

This repository is home to core Dart packages.
https://pub.dev/publishers/dart.dev
BSD 3-Clause "New" or "Revised" License
19 stars 7 forks source link

add links to the package issue trackers #720

Closed devoncarew closed 3 weeks ago

devoncarew commented 3 weeks ago

Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
github-actions[bot] commented 3 weeks ago

Package publishing

Package Version Status Publish tag (post-merge)
package:characters 1.4.0 ready to publish characters-v1.4.0
package:args 2.6.1-wip WIP (no publish necessary)
package:async 2.12.0 already published at pub.dev
package:collection 1.19.1-wip WIP (no publish necessary)
package:convert 3.1.2 already published at pub.dev
package:crypto 3.0.6 already published at pub.dev
package:fixnum 1.1.1 already published at pub.dev
package:logging 1.3.0 already published at pub.dev
package:os_detect 2.0.3-wip WIP (no publish necessary)
package:path 1.9.1 already published at pub.dev
package:platform 3.1.6 already published at pub.dev
package:typed_data 1.4.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

github-actions[bot] commented 3 weeks ago

PR Health

Coverage :heavy_check_mark: | File | Coverage | | :--- | :--- | This check for [test coverage](https://github.com/dart-lang/ecosystem/wiki/Test-Coverage) is informational (issues shown here will not fail the PR).
API leaks :warning: The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API. | Package | Leaked API symbols | | :--- | :--- | |path|InternalStyle| This check can be disabled by tagging the PR with `skip-leaking-check`.
License Headers :heavy_check_mark: ``` // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. ``` | Files | | :--- | | _no missing headers_ | All source files should start with a [license header](https://github.com/dart-lang/ecosystem/wiki/License-Header).
devoncarew commented 3 weeks ago

Skipping the changelog check; we'll capture the issue_tracker pubspec change organically w/ the next update to each package.

devoncarew commented 3 weeks ago

The health check failure here may be related to the api diff tool:

Look for changes in package:fixnum 1.1.1 (dir=/home/runner/work/core/core/current_repo/pkgs/fixnum) with base Directory: '../base_repo'
Error: Error while creating the diff: Bad state: Too many elements
#0      Iterable.single (dart:core/iterable.dart:677:24)
#1      PackageApiDiffer._diffIterables (package:dart_apitool/src/diff/package_api_differ.dart:1344:45)
#2      PackageApiDiffer._calculateExecutablesDiff (package:dart_apitool/src/diff/package_api_differ.dart:266:32)
#3      PackageApiDiffer._calculateInterfaceDiff.<anonymous closure> (package:dart_apitool/src/diff/package_api_differ.dart:180:12)
#4      PackageApiDiffer._executeInContext (package:dart_apitool/src/diff/package_api_differ.dart:1263:23)
#5      PackageApiDiffer._calculateInterfaceDiff (package:dart_apitool/src/diff/package_api_differ.dart:175:12)
#6      PackageApiDiffer._calculateInterfacesDiff (package:dart_apitool/src/diff/package_api_differ.dart:137:22)
#7      PackageApiDiffer.diff (package:dart_apitool/src/diff/package_api_differ.dart:47:12)
#8      DiffCommand.run (package:dart_apitool/src/cli/commands/diff_command.dart:188:16)
<asynchronous suspension>
#9      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#10     main (file:///home/runner/.pub-cache/hosted/pub.dev/dart_apitool-0.20.0/bin/main.dart:28:22)