bwilkerson
commented
2 months ago See also https://github.com/dart-lang/sdk/issues/56213, and note that the experiment name used here is different from the name used in the SDK issues.
Open pq opened 2 months ago
bwilkerson
commented
2 months ago See also https://github.com/dart-lang/sdk/issues/56213, and note that the experiment name used here is different from the name used in the SDK issues.
pq
commented
1 month ago I'm making my way through the lints and thinking in general that they should "just work". If any exceptions jump out at anyone, I'd be grateful for the input!
/cc @eernstg @bwilkerson @lrhn
srawlins
commented
1 month ago avoid_relative_lib_imports is checked as complete, but I don't see new tests for imports in parts.conditional_uri_does_not_exist: same.implementation_imports: same.library_annotations: the impl needs changing I think, so that it returns early if it finds a PartOfDirective, so that it doesn't suggest adding a library directive in a part file.prefer_relative_imports: same.
eernstg
commented
1 month ago A couple of other things came to mind:
<partHeader> (part of ...), but it seems plausible that this DartDoc comment could play a role for the part which is similar to the role played by a DartDoc comment on a <libraryName> for the library as a whole. Perhaps it needs an update or a test?
lrhn
commented
1 month ago For dangling_library_doc_comments, it only seem to apply to the library file, so no change should be necessary.
I don't expect doc-comments on part of directives to behave differently from today. I don't know what they do today, but I'd expect them to be either ignored or concatenated with the library documentation from the library file. (Testing: Seems to be ignored.)
All the ones that refer to URIs or imports should definitely not bail out early on seeing part of. Then they should behave the same for the imports and URIs they find.
library_annotations shouldn't need changing. It can find a part of directive today, so nothing changed there. Any issues are pre-existing.
A meta-issue to discuss and track work on linter support for enhanced-parts.
Feature.enhanced_partsExisting Lints
Some existing lints will need tests (minimally) and possibly enhanced implementations.
always_declare_return_typesalways_put_control_body_on_new_linealways_put_required_named_parameters_firstalways_specify_typesannotate_overridesannotate_redeclares[experimental]avoid_annotating_with_dynamicavoid_bool_literals_in_conditional_expressionsavoid_catches_without_on_clausesavoid_catching_errorsavoid_classes_with_only_static_membersavoid_double_and_int_checksavoid_dynamic_callsavoid_empty_elseavoid_equals_and_hash_code_on_mutable_classesavoid_escaping_inner_quotesavoid_field_initializers_in_const_classesavoid_final_parametersavoid_function_literals_in_foreach_callsavoid_implementing_value_typesavoid_init_to_nullavoid_js_rounded_intsavoid_multiple_declarations_per_lineavoid_null_checks_in_equality_operatorsavoid_positional_boolean_parametersavoid_printavoid_private_typedef_functionsavoid_redundant_argument_valuesavoid_renaming_method_parametersavoid_return_types_on_settersavoid_returning_null_for_voidavoid_returning_thisavoid_setters_without_gettersavoid_shadowing_type_parametersavoid_single_cascade_in_expression_statementsavoid_slow_async_ioavoid_type_to_stringavoid_types_as_parameter_namesavoid_types_on_closure_parametersavoid_unnecessary_containersavoid_unused_constructor_parametersavoid_void_asyncavoid_web_libraries_in_flutterawait_only_futurescamel_case_extensionscamel_case_typescancel_subscriptionscascade_invocationscast_nullable_to_non_nullableclose_sinkscollection_methods_unrelated_typecombinators_orderingcomment_referencesconstant_identifier_namescontrol_flow_in_finallycurly_braces_in_flow_control_structuresdangling_library_doc_commentsdepend_on_referenced_packagesdeprecated_consistencydeprecated_member_use_from_same_packagediagnostic_describe_all_propertiesdirectives_orderingdiscarded_futuresdocument_ignoresdo_not_use_environmentempty_catchesempty_constructor_bodiesempty_statementseol_at_end_of_fileerase_dart_type_extension_typesexhaustive_casesfile_namesflutter_style_todoshash_and_equalsimplicit_call_tearoffsimplicit_reopen[experimental]invalid_case_patterns[experimental]join_return_with_assignmentinvalid_runtime_check_with_js_interop_typesleading_newlines_in_multiline_stringslibrary_nameslibrary_prefixeslibrary_private_types_in_public_apilines_longer_than_80_charsliteral_only_boolean_expressionsmatching_super_parametersmissing_code_block_language_in_doc_commentmissing_whitespace_between_adjacent_stringsno_adjacent_strings_in_listno_default_cases[experimental]no_duplicate_case_valuesno_leading_underscores_for_library_prefixesno_leading_underscores_for_local_identifiersno_literal_bool_comparisonsno_logic_in_create_stateno_runtimeType_toStringno_self_assignmentsno_wildcard_variable_usesnon_constant_identifier_namesnoop_primitive_operationsnull_check_on_nullable_type_parameternull_closuresomit_local_variable_typesomit_obvious_local_variable_types[experimental]one_member_abstractsonly_throw_errorsoverridden_fieldspackage_api_docspackage_namespackage_prefixed_library_namesparameter_assignmentsprefer_adjacent_string_concatenationprefer_asserts_in_initializer_listsprefer_asserts_with_messageprefer_collection_literalsprefer_conditional_assignmentprefer_const_constructorsprefer_const_constructors_in_immutablesprefer_const_declarationsprefer_const_literals_to_create_immutablesprefer_constructors_over_static_methodsprefer_containsprefer_double_quotesprefer_expression_function_bodiesprefer_final_fieldsprefer_final_in_for_eachprefer_final_localsprefer_final_parametersprefer_for_elements_to_map_fromIterableprefer_foreachprefer_function_declarations_over_variablesprefer_generic_function_type_aliasesprefer_if_elements_to_conditional_expressionsprefer_if_null_operatorsprefer_initializing_formalsprefer_inlined_addsprefer_int_literalsprefer_interpolation_to_compose_stringsprefer_is_emptyprefer_is_not_emptyprefer_is_not_operatorprefer_iterable_whereTypeprefer_mixinprefer_null_aware_method_callsprefer_null_aware_operatorsprefer_single_quotesprefer_spread_collectionsprefer_typing_uninitialized_variablesprefer_void_to_nullprovide_deprecation_messagerecursive_gettersrequire_trailing_commassecure_pubspec_urlssized_box_for_whitespacesized_box_shrink_expandslash_for_doc_commentssort_child_properties_lastsort_constructors_firstsort_pub_dependenciessort_unnamed_constructors_firsttest_types_in_equalsthrow_in_finallytighten_type_of_initializing_formalstype_annotate_public_apistype_init_formalstype_literal_in_constant_patternunawaited_futuresunintended_html_in_doc_commentunnecessary_await_in_returnunnecessary_brace_in_string_interpsunnecessary_breaksunnecessary_constunnecessary_constructor_nameunnecessary_finalunnecessary_getters_settersunnecessary_lambdasunnecessary_lateunnecessary_library_directiveunnecessary_library_nameunnecessary_newunnecessary_null_aware_assignmentsunnecessary_null_aware_operator_on_extension_on_nullableunnecessary_null_checks[experimental]unnecessary_null_in_if_null_operatorsunnecessary_nullable_for_final_variable_declarationsunnecessary_overridesunnecessary_parenthesisunnecessary_raw_stringsunnecessary_statementsunnecessary_string_escapesunnecessary_string_interpolationsunnecessary_thisunnecessary_to_list_in_spreadsunreachable_from_mainunrelated_type_equality_checksunsafe_htmluse_build_context_synchronouslyuse_colored_boxuse_decorated_boxuse_enumsuse_full_hex_values_for_flutter_colorsuse_function_type_syntax_for_parametersuse_if_null_to_convert_nulls_to_boolsuse_is_even_rather_than_modulouse_key_in_widget_constructorsuse_late_for_private_fields_and_variables[experimental]use_named_constantsuse_raw_stringsuse_rethrow_when_possibleuse_setters_to_change_propertiesuse_string_buffersuse_super_parameters[experimental]use_test_throws_matchersuse_to_and_as_if_applicablevalid_regexpsvoid_checksGeneral Part Support
There are a number of outstanding issues with our support for parts. In support of this feature (and in anticipation) of greater adoption of parts, we might consider prioritizing some fixes.
https://github.com/dart-lang/linter/issues/4945