Open dcharkes opened 3 months ago
I've fixed all the flakes I could find, but there are some that I can't repro locally. I've done my best to fix those too, but I might have missed some. Please reopen or file another issue if there are more flakes on CI.
global_test and global_native_test are still flaky. Can't repro locally.
https://github.com/dart-lang/native/actions/runs/10605979638/job/29397792224
Might have gotten less flaky, but it's not fixed: https://github.com/dart-lang/native/actions/runs/11470847451/job/31920895855?pr=1673
It passes 10 runs in a row pretty easily: https://github.com/dart-lang/native/actions/runs/11471378290/job/31922174382?pr=1674
I wonder if the build or other setup is flaky. I've changed the workflow so that it completes all 10 runs even if one fails. Maybe we'll see that it's still ~30% flaky, but when it does flake it fails all 10 runs. That would explain why my "run 10 times" strategy failed to detect the flake in #1666.
Yep, finally got a flake, and all 10 test runs failed. Probably the build is flaky. Next step is to try and get the build artifacts from CI and see whats going on.
While reviewing https://github.com/dart-lang/native/pull/1434/:
After rerunning the test passed.
cc @liamappelbe