update changelogs per https://github.com/dart-lang/test/pull/2262

dart-lang / test

A library for writing unit tests in Dart.

https://pub.dev/packages/test

496 stars 214 forks source link

update changelogs per https://github.com/dart-lang/test/pull/2262 #2267

Closed jakemac53 closed 3 months ago

natebosch commented 3 months ago

The changes aren't user facing (not even to ourselves as users of the packages). I'd be inclined to skip the changelog check if it had already been enabled on that PR.

I don't know if we've ever decided on concrete guidelines for when to include or omit changelog changes. Maybe we should...

jakemac53 commented 3 months ago

This is user facing - dart2wasm was broken on windows entirely afaik, and now it will work. Maybe the wording is confusing though?

In other words, what changed isn't that our internal dart2wasm tests now pass, its that dart2wasm tests in general can now work on windows.

natebosch commented 3 months ago

I misread the linked PR.