search

dart-lang / test

A library for writing unit tests in Dart.
https://pub.dev/packages/test
496 stars 214 forks source link

require approval from core-package-admins for anything under /pkgs #2268

Closed jakemac53 closed 3 months ago

jakemac53 commented 3 months ago

Trying out the CODEOWNERS workflows, we can remove this if it is annoying.

Any dart-lang admin can edit that group so we can always get something landed if needed that way, but it will require some explicit steps from an admin.

github-actions[bot] commented 3 months ago

PR Health

Breaking changes :heavy_check_mark:

Details | Package | Change | Current Version | New Version | Needed Version | Looking good? | | :--- | :--- | ---: | ---: | ---: | ---: |

Changelog Entry :heavy_check_mark:

Details | Package | Changed Files | | :--- | :--- | Changes to files need to be [accounted for](https://github.com/dart-lang/ecosystem/wiki/Changelog) in their respective changelogs.

Coverage :heavy_check_mark:

Details | File | Coverage | | :--- | :--- | This check for [test coverage](https://github.com/dart-lang/ecosystem/wiki/Test-Coverage) is informational (issues shown here will not fail the PR).

API leaks :heavy_check_mark:

Details The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API. | Package | Leaked API symbols | | :--- | :--- |

License Headers :heavy_check_mark:

Details ``` // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. ``` | Files | | :--- | | _no missing headers_ | All source files should start with a [license header](https://github.com/dart-lang/ecosystem/wiki/License-Header).
Unrelated files missing license headers | Files | | :--- | |pkgs/checks/test/failure_message_test.dart|

Package publish validation :heavy_check_mark:

Details | Package | Version | Status | | :--- | ---: | :--- | | package:checks | 0.3.1-wip | WIP (no publish necessary) | | package:test | 1.25.9-wip | WIP (no publish necessary) | | package:test_api | 0.7.4-wip | WIP (no publish necessary) | | package:test_core | 0.6.6-wip | WIP (no publish necessary) | Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
natebosch commented 3 months ago

The github diff view is showing an "Unknown Owner" warning that the group needs to be public. I'm not sure if that will prevent it from working.

natebosch commented 3 months ago

Maybe @kevmoo has a suggestion.

For context, we'd like to limit reviewers for PRs in the test repo since the tight coupling (both within the repo, and with flutter and google3) can make it tricker to land things.

devoncarew commented 3 months ago

I changed the team to public; I think that'll address the error.