search

dart-lang / test

A library for writing unit tests in Dart.
https://pub.dev/packages/test
496 stars 214 forks source link

Skip some wasm tests #2285

Closed natebosch closed 1 month ago

natebosch commented 2 months ago

Skip some wasm integration tests in chrome and on windows. Add a dart2js test to run in firefox on linux which can start, but currently fails because it runs no test cases.

github-actions[bot] commented 2 months ago

PR Health

Changelog Entry :heavy_check_mark: | Package | Changed Files | | :--- | :--- | Changes to files need to be [accounted for](https://github.com/dart-lang/ecosystem/wiki/Changelog) in their respective changelogs.
Package publish validation :heavy_check_mark: | Package | Version | Status | | :--- | ---: | :--- | | package:checks | 0.3.1-wip | WIP (no publish necessary) | | package:test | 1.25.9-wip | WIP (no publish necessary) | | package:test_api | 0.7.4-wip | WIP (no publish necessary) | | package:test_core | 0.6.6-wip | WIP (no publish necessary) | Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
osa1 commented 1 month ago

What is this fixing exactly? The referenced issue in the comments is 2 years old and referring to a time when dart2wasm could run hello world plus a few other programs. It's feature complete now with only a few known bugs. The CI runs in the main branch are also all green.

natebosch commented 1 month ago

This was just trying to unblock CI for the failures with the old SDK. I reused the stale issue instead of filing a new one just so we had something to track unskipping them.

The failures are resolved by #2286 so I'll close this one.

We might still want to look in to the weird behavior on firefox.