dart-lang / web

Lightweight browser API bindings built around JS static interop.
https://pub.dev/packages/web
BSD 3-Clause "New" or "Revised" License
135 stars 23 forks source link

Add MAC_FF_META to KeyCode constants #264

Closed arnaud-secondlayer closed 4 months ago

arnaud-secondlayer commented 4 months ago

This PR adds the missing declaration of MAC_FF_META key code value to the KeyCode constants. MAC_Fleur_META (value is 224) is fired by Firefox on macOS when pressing the META key, instead of the common META key value (91).

I kept the same comment as Closure's Keycode enumeration.


Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.