Closed dkgs closed 9 years ago
Looks like it does not build. Can you check what's up with that?
From an API point of view the change sounds good. I'll look into the details a bit more to see what's going on with the build error. Thanks!
On my side, I only tested under msvc10 on an other machine which doesn't have a direct internet connection, then I may have made a mistake reporting my modifications. Errors seems to come from clang and gcc compilers. I'll look into it.
Code change looks fine too; I think Clang/GCC complain about the inline pure-virtual-with-initializer syntax you use. I think it's not valid but that MSVC accepts it regardless.
Destructors corrected, clang is now fine. But gcc does complain about "forming reference to reference" that should be due to my edits in hippomocks.h. I'll check.
Yeah it passed :)
Merged - thanks!
I propose the following modifications tu support return const ref values.
At first, I did the modification bu overloading the return function the following way :
But It was fastidious to use :
Then I prefered adding a new Return function named ReturnByRef() it is more explicit to me.