search

dashpay / electrum-dash-old

Electrum-DASH - a Dash thin client
https://electrum-dash.org
MIT License
37 stars 112 forks source link

Undocumented dependency on C code, unnecessary dependency on Trezor #66

Open fortran77 opened 7 years ago

fortran77 commented 7 years ago

I followed the official instructions to install the development release (on Ubuntu 14.04.4 LTS) by doing git clone https://github.com/dashpay/electrum-dash.git then sudo python setup.py install (note the undocumented sudo requirment). The install failed because the setup script tried to install Trazor-related libraries and failed.

There seem to be two problems here.

  1. The documentation says that electrum-dash is a pure python application, yet the install procedure requires C code to be compiled. Although code billed as pure python sometimes requires C libraries, generally it's expected that the OS will supply these libraries. If we are going to pull in any other C libraries, then our application should not be referred to as a pure python application. The advantage of pure python code is that it will work anywhere where a python interpreter is present, independent of any C development environment, and that is obviously not true if we are pulling in C code that must be compiled.
  2. The Trezor requirement is unnecessarily harsh. Hardware support should be required only if that hardware is actually going to be used.