dashpay / platform

L2 solution for seriously fast decentralized applications for the Dash network
https://dashplatform.readme.io/docs/introduction-what-is-dash-platform
MIT License
74 stars 39 forks source link

feat(platform): get identities for non unique public key hash #2324

Open QuantumExplorer opened 2 weeks ago

QuantumExplorer commented 2 weeks ago

Issue being fixed or feature implemented

We had no way to get identities having a non unique public key hash. This would cause a problem trying to looking identities by public keys that are hashes in the state.

What was done?

Added the ability to lookup identities by non unique public key hash.

How Has This Been Tested?

Added a few unit tests.

Breaking Changes

Nothing should be breaking.

Checklist:

For repository code-owners and collaborators only

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The changes in this pull request introduce new functionalities to handle identities associated with non-unique public key hashes across various modules. Key additions include the getIdentitiesForNonUniquePublicKeyHash RPC method and corresponding request/response message types in the platform.proto file. Additionally, several new methods and modules have been created in the rs-drive-abci and rs-sdk packages to support querying and verifying identities based on non-unique public key hashes. Various existing methods have also been updated for consistency with the new features.

Changes

File Change Summary
packages/dapi-grpc/protos/platform/v0/platform.proto Added RPC method getIdentitiesForNonUniquePublicKeyHash and new message types GetIdentitiesForNonUniquePublicKeyHashRequest and GetIdentitiesForNonUniquePublicKeyHashResponse.
packages/rs-drive-abci/src/query/identity_based_queries/identities_for_non_unique_public_key_hash/mod.rs Introduced module for querying identities with method query_identities_for_non_unique_public_key_hash.
packages/rs-drive-abci/src/query/identity_based_queries/identities_for_non_unique_public_key_hash/v0/mod.rs Added method query_identities_for_non_unique_public_key_hash_v0 for handling identity queries.
packages/rs-drive-abci/src/query/identity_based_queries/mod.rs Added new module identities_for_non_unique_public_key_hash.
packages/rs-drive-abci/src/query/service.rs Introduced method get_identities_for_non_unique_public_key_hash in PlatformService trait.
packages/rs-drive/src/drive/identity/fetch/fetch_by_public_key_hashes/fetch_full_identities_for_non_unique_public_key_hash/mod.rs Added method fetch_full_identities_for_non_unique_public_key_hash.
packages/rs-drive/src/drive/identity/fetch/fetch_by_public_key_hashes/fetch_full_identities_for_non_unique_public_key_hash/v0/mod.rs Introduced methods for fetching identities based on non-unique public key hashes.
packages/rs-drive/src/drive/identity/fetch/fetch_by_public_key_hashes/fetch_identity_ids_by_non_unique_public_key_hash/mod.rs Modified method to include an optional limit parameter.
packages/rs-drive/src/drive/identity/fetch/fetch_by_public_key_hashes/fetch_identity_ids_by_non_unique_public_key_hash/v0/mod.rs Updated methods to include limit parameter for fetching identity IDs.
packages/rs-drive/src/drive/identity/fetch/fetch_by_public_key_hashes/mod.rs Added module for fetching full identities.
packages/rs-drive/src/drive/identity/fetch/prove/mod.rs Introduced module for proving identities associated with non-unique public key hashes.
packages/rs-drive/src/verify/identity/mod.rs Added modules for verifying identities associated with non-unique public key hashes.
packages/rs-platform-version/src/version/drive_abci_versions/drive_abci_query_versions/mod.rs Added fields to support new identity query features.
packages/rs-platform-version/src/version/drive_versions/drive_identity_method_versions/mod.rs Added fields for fetching and proving identities with non-unique public key hashes.
packages/rs-sdk/src/platform/fetch_many.rs Added implementation for fetching identities based on non-unique public key hashes.
packages/rs-sdk/src/platform/types/identity.rs Introduced new struct NonUniquePublicKeyHash for handling non-unique public key hashes.

Suggested reviewers

🐰 In the meadow, hopping around,
New features for identities we have found!
With hashes that aren't unique, oh what a sight,
Fetching and proving, all feels just right!
So let’s celebrate this code, oh so bright! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.