search

dask-contrib / dask-awkward

Native Dask collection for awkward arrays, and the library to use it.
https://dask-awkward.readthedocs.io
BSD 3-Clause "New" or "Revised" License
61 stars 19 forks source link

[fix] Solve circular imports #546

Closed martindurant closed 2 months ago

martindurant commented 2 months ago

Fixes #544

martindurant commented 2 months ago

This fails while importing dask-histogram; https://github.com/dask-contrib/dask-histogram/pull/151 fails while importing dask-awkward (without this fix). Locally, installing both fixes things.

martindurant commented 2 months ago

OK, so I can confirm that this works. I would like to have someone's OK in it, but I think we'd have to marge the PRs in both repos and release before things go green again.

lgray commented 2 months ago

It appears to still be failing for this reason in some cases: https://github.com/dask-contrib/dask-awkward/actions/runs/10906809560/job/30268939135?pr=546#step:4:1372

martindurant commented 2 months ago

I changed the env only for the "pypi tests" and "conda tests" runs, and they all pass.

Since there has been no response at all in the dask/dask issue, I intend to merge and release the two fix PRs this afternoon.

lgray commented 2 months ago

Got it - please go ahead and do all the necessary merging so we can have a release.

I imagine someone on dask will reply in time.