dask-contrib / dask-ctl

Tools to provide a control plane for managing the lifecycle of Dask clusters.
https://dask-ctl.readthedocs.io
BSD 3-Clause "New" or "Revised" License
24 stars 14 forks source link

remove coverage argument from pytest addopts config #29

Closed alisterburt closed 2 years ago

alisterburt commented 2 years ago

When running pytest locally I get

(dask-ctl) ➜  dask-ctl git:(main) pytest                    
ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: unrecognized arguments: --cov=./
  inifile: /Users/aburt/Programming/dask-ctl/setup.cfg
  rootdir: /Users/aburt/Programming/dask-ctl

this PR solves the issue for me but might break anything you do with the coverage results

I'm also not sure why this runs on CI/for you but not for me...

jacobtomlinson commented 2 years ago

Are you installing the test dependencies? The --cov flag is added by the pytest-cov package.

https://github.com/dask-contrib/dask-ctl/blob/main/requirements-test.txt

alisterburt commented 2 years ago

missed that file, my bad!

jacobtomlinson commented 2 years ago

Be sure to checkout the contributing docs as that covers linting and testing.