search

dask-contrib / dask-ctl

Tools to provide a control plane for managing the lifecycle of Dask clusters.
https://dask-ctl.readthedocs.io
BSD 3-Clause "New" or "Revised" License
24 stars 14 forks source link

silence a deprecation #34

Closed keewis closed 2 years ago

keewis commented 2 years ago

Unlike the import in dask_ctl.lifecycle, dask_ctl.cli still imports distributed.utils.typename.

codecov-commenter commented 2 years ago

Codecov Report

Merging #34 (df80fb2) into main (749a65a) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   79.71%   79.71%           
=======================================
  Files           9        9           
  Lines         345      345           
=======================================
  Hits          275      275           
  Misses         70       70
Impacted Files Coverage Δ
dask_ctl/cli.py 67.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 749a65a...df80fb2. Read the comment docs.

jacobtomlinson commented 2 years ago

Test failures look unrelated to this.

jacobtomlinson commented 2 years ago

Thanks @jrbourbeau. I've changed that but looks like we are still blocked on #38

jacobtomlinson commented 2 years ago

Superseded by #39