search

dask / dask-searchcv

dask-searchcv is now part of dask-ml: https://github.com/dask/dask-ml
BSD 3-Clause "New" or "Revised" License
240 stars 43 forks source link

COMPAT: Dask master and sklearn 0.18 #7

Closed TomAugspurger closed 7 years ago

TomAugspurger commented 8 years ago

I'm assuming that we don't need to worry too much about backwards compatibility here, though if we do I can put in a compatibility layer. As it stands, the changes to dklearn.cross_validation will mean that dklearn requires dask 0.12+ (for the changes in random_state_data, cc @jcrist )

There are also a couple changes for scikit-learn 0.18 compatibility. I think these changes should be ok for older versions of scikit-learn.

I'm trying out dklearn today, I'll report back with issues / successes :)

mrocklin commented 8 years ago

Glad to see activity and interest here. I agree that we can probably be bleeding edge here for a while.

TomAugspurger commented 8 years ago

Glad to see activity and interest here.

My (regular, scikit-learn) grid search pipeline that's been running for ~12 hours now because of an expensive step early step in the pipeline, that can be shared across all the grid-search steps, is making this more compelling :)

mrocklin commented 8 years ago

Ha, indeed. If you happen to have a few computers nearby you could also try scaling out a bit. Not sure if that's worth it in your case though.

jcrist commented 8 years ago

Happy to merge when green, or hold off if you have more fixes later. Up to you.

mrocklin commented 7 years ago

It looks like we've failed to merge here. @jcrist is everything here still good?

jcrist commented 7 years ago

Yeah. I'll just merge this now, other changes can come later.