dask / distributed

A distributed task scheduler for Dask
https://distributed.dask.org
BSD 3-Clause "New" or "Revised" License
1.57k stars 718 forks source link

Improved errors and reduced logging for P2P RPC calls #8666

Closed hendrikmakait closed 3 months ago

hendrikmakait commented 3 months ago

Reduces the noise created by P2P restarts and adds P2P-specific errors to facilitate error handling/catching.

github-actions[bot] commented 3 months ago

Unit Test Results

_See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests._

    29 files  ±    0      29 suites  ±0   11h 8m 28s :stopwatch: + 1h 17m 58s  4 056 tests  -     3   3 953 :white_check_mark: +    9     97 :zzz:  -   9  6 :x: +1  55 869 runs  +7 611  53 699 :white_check_mark: +7 377  2 163 :zzz: +250  7 :x: +1 

For more details on these failures, see this check.

Results for commit 0c9149c6. ± Comparison against base commit cbc21dff.

This pull request removes 14 and adds 11 tests. Note that renamed tests count towards both. ``` distributed.protocol.tests.test_arrow distributed.protocol.tests.test_collection distributed.protocol.tests.test_highlevelgraph distributed.protocol.tests.test_numpy distributed.protocol.tests.test_pandas distributed.shuffle.tests.test_graph distributed.shuffle.tests.test_merge distributed.shuffle.tests.test_merge_column_and_index distributed.shuffle.tests.test_metrics distributed.shuffle.tests.test_rechunk … ``` ``` distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[False] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[report_args0] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[1] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[False] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[True] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[False] distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[report_args0] distributed.http.scheduler.tests.test_scheduler_http ‑ test_prometheus_collect_task_groups distributed.shuffle.tests.test_shuffle ‑ test_error_receive[P2PConsistencyError] … ```

:recycle: This comment has been updated with latest results.