search

data-for-change / anyway

ANYWAY - Car accidents map
http://www.anyway.co.il
MIT License
77 stars 242 forks source link

Set road_segment_id in news_flash of Suburban resolution. #2577

Closed ziv17 closed 6 months ago

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 53.19%. Comparing base (624c5fc) to head (89b6e24).

Files Patch % Lines
anyway/parsers/location_extraction.py 7.14% 13 Missing :warning:
anyway/parsers/news_flash.py 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2577 +/- ## ========================================== - Coverage 53.27% 53.19% -0.09% ========================================== Files 119 119 Lines 9882 9898 +16 ========================================== Hits 5265 5265 - Misses 4617 4633 +16 ``` | [Flag](https://app.codecov.io/gh/data-for-change/anyway/pull/2577/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/data-for-change/anyway/pull/2577/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `53.19% <21.05%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ziv17 commented 7 months ago

Hi @atalyaalon , This PR is the first part of issue #2567. It sets road_segment_id in news_flash items. After it is merged, we should update all news_flash items to set road_segment_id in them. Note: