search

data-for-change / anyway

ANYWAY - Car accidents map
http://www.anyway.co.il
MIT License
75 stars 242 forks source link

2478 add streets table from datagov #2668

Closed ziv17 closed 3 weeks ago

codecov-commenter commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 6.41026% with 73 lines in your changes missing coverage. Please review.

Project coverage is 53.20%. Comparing base (400af13) to head (24ea9d1). Report is 52 commits behind head on dev.

Files Patch % Lines
anyway/parsers/streets.py 0.00% 62 Missing :warning:
anyway/parsers/infographics_data_cache_updater.py 25.00% 6 Missing :warning:
main.py 0.00% 5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2668 +/- ## ========================================== - Coverage 53.22% 53.20% -0.02% ========================================== Files 119 120 +1 Lines 9924 10072 +148 ========================================== + Hits 5282 5359 +77 - Misses 4642 4713 +71 ``` | [Flag](https://app.codecov.io/gh/data-for-change/anyway/pull/2668/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/data-for-change/anyway/pull/2668/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `53.20% <6.41%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

atalyaalon commented 1 week ago

@ziv17 Great work! It's already merged to dev but not to master yet: I'm waiting for the CBS final answer that our method is correct for the merge. In addition, before merging to production I suggest you also remove the code that updates the streets table from CBS data (this code is in cbs anyway/parsers/cbs/executor.py) - I opened an issue for this: https://github.com/data-for-change/anyway/issues/2674

However, let's wait for the final answer of the CBS and then implement this last part