search

database64128 / youtube-dl-wpf

A simple GUI wrapper for youtube-dl and yt-dlp.
GNU General Public License v3.0
873 stars 68 forks source link

-merge-output-format and -f question #177

Open astering opened 11 months ago

astering commented 11 months ago

Hello, I find some weird bugs, if I let the preset "format" empty, the content of "container" will be set as argument of "-f".

For example, format = best, container = mkv, the it will be: -f best -merge-output-format mkv,

but if format is empty, container = mkv, then the argument is -f mkv.

I want to have mkv as output,merge some subtitles, but the stream maybe vp9 or h264, some videos don't have mkv, and will cause unexpected behavior.

database64128 commented 11 months ago

When I first wrote this, I made the assumption based on my understanding of the documentation that specifying --merge-output-format alone was equivalent to specifying --format with the same argument. Looks like I was wrong.

Fixing this would require a breaking change to the preset mechanism, which might break some existing user-defined presets. But it's probably the right thing to do. For now, you can leave both format and container empty, and specify --merge-output-format, mkv as extra arguments.

astering commented 11 months ago

For now, you can leave both format and container empty, and specify --merge-output-format, mkv as extra arguments.

Yeh, that's what I set now. Thanks to custom parameters, setting any suitable parameters is always feasible.