databendlabs / databend

๐——๐—ฎ๐˜๐—ฎ, ๐—”๐—ป๐—ฎ๐—น๐˜†๐˜๐—ถ๐—ฐ๐˜€ & ๐—”๐—œ. Modern alternative to Snowflake. Cost-effective and simple for massive-scale analytics. https://databend.com
https://docs.databend.com
Other
7.71k stars 732 forks source link

fix(iceberg): Handling options like "s3.region" #16404

Closed Xuanwo closed 3 weeks ago

Xuanwo commented 3 weeks ago

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Our parser doesn't allow users to write s3.region in options. Instead, users must use "s3.region", but it's stored as is which makes the behavior in wrong. We need to remove the quotes here.

We only do this while building catalog so this won't affect existing catalogs.

Tests

Type of change


This change isโ€‚Reviewable

what-the-diff[bot] commented 3 weeks ago

PR Summary