chore: simplify get_sequence() and get_sequence_next_value() - Githubissues

databendlabs / databend

𝗗𝗮𝘁𝗮, 𝗔𝗻𝗮𝗹𝘆𝘁𝗶𝗰𝘀 & 𝗔𝗜. Modern alternative to Snowflake. Cost-effective and simple for massive-scale analytics. https://databend.com

https://docs.databend.com

Other

7.71k stars 732 forks source link

chore: simplify get_sequence() and get_sequence_next_value() #16463

Closed drmingdrmer closed 1 week ago

drmingdrmer commented 1 week ago

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore: simplify get_sequence() and get_sequence_next_value()

refactor: simplify get_sequence() API to return Option instead of Result

Change return type from Result to Option
Return None when sequence is not found
This allows callers to easily distinguish between "not found" and other errors

chore: replace manually defined `Sequence` error with Unknown/Exist Error with generic

chore: add test to `SequenceIdent`

Tests

[x] Unit Test
[ ] Logic Test
[ ] Benchmark Test
[ ] No Test - Explain why

Type of change

[x] Refactoring

Related Issues

This change is