chore(query): null first behavior - Githubissues

databendlabs / databend

𝗗𝗮𝘁𝗮, 𝗔𝗻𝗮𝗹𝘆𝘁𝗶𝗰𝘀 & 𝗔𝗜. Modern alternative to Snowflake. Cost-effective and simple for massive-scale analytics. https://databend.com

https://docs.databend.com

Other

7.71k stars 732 forks source link

chore(query): null first behavior #16475

Closed sundy-li closed 6 days ago

sundy-li commented 1 week ago

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Add settings default_order_by_null defaults to nulls_last.

PG and snowflake use default value nulls_last_on_asc_first_on_desc.

If we change the default value to nulls_last_on_asc_first_on_desc, it's the same as PG but incompatible with the previous version.

Also fix a bug in stats from external parquet file.

Tests

[ ] Unit Test
[x] Logic Test
[ ] Benchmark Test
[ ] No Test - Explain why

Type of change

[x] Bug Fix (non-breaking change which fixes an issue)
[ ] New Feature (non-breaking change which adds functionality)
[ ] Breaking Change (fix or feature that could cause existing functionality not to work as expected)
[ ] Documentation Update
[x] Refactoring
[ ] Performance Improvement
[ ] Other (please describe):

This change is