Open arkzuse opened 3 days ago
Hi @arkzuse
Thanks for the contribution! This PR is not yet ready for review, so I've converted it to a draft. Please mark it as 'READY' when you believe it's ready for review.
@BohuTANG sorry for the oversight. What can I do to make it review ready?
@BohuTANG sorry for the oversight. What can I do to make it review ready?
Currently, the settings are only defined. We need to implement them in the short_sql
func:
https://github.com/datafuselabs/databend/blob/8eaf57b52cc56929291d5d3b25c696c0bd4a2252/src/common/base/src/base/string.rs#L196-L198
Something like short_sql(sql String, max_length: usize) ...
You can refer to other settings for guidance on how to get
and set
values.
Finally, please add a test for this PR. Once all tests pass, it will be ready for review, and the tests can reference the other settings.
@arkzuse Hi, could you clarify why the PR was closed? Let me know if you need any help to continue.
@BohuTANG I didn't close it. I am working on this pr and interested to contribute in future.
Oh i deleted my local brach so it closed... sorry for inconvenience
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
New setting for short length sql.
Tests
Type of change
This change isโ