feat(query): DATE_ADD Functions to support week as a unit - Githubissues

databendlabs / databend

𝗗𝗮𝘁𝗮, 𝗔𝗻𝗮𝗹𝘆𝘁𝗶𝗰𝘀 & 𝗔𝗜. Modern alternative to Snowflake. Cost-effective and simple for massive-scale analytics. https://databend.com

https://docs.databend.com

Other

7.71k stars 732 forks source link

feat(query): DATE_ADD Functions to support week as a unit #16530

Open TracyZYJ opened 13 hours ago

TracyZYJ commented 13 hours ago

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

date_add support week as unit.

SELECT DATE_ADD('week', 1, TODAY())=DATE_ADD('day', 7, TODAY())

fixes: https://github.com/databendlabs/databend/issues/16402

Tests
[x] Unit Test
[x] Logic Test
[ ] Benchmark Test
[ ] No Test - Explain why

Type of change

[ ] Bug Fix (non-breaking change which fixes an issue)
[x] New Feature (non-breaking change which adds functionality)
[ ] Breaking Change (fix or feature that could cause existing functionality not to work as expected)
[ ] Documentation Update
[ ] Refactoring
[ ] Performance Improvement
[ ] Other (please describe):

This change is

TCeason commented 10 hours ago

LGTM. Please review this pr @b41sh