search

databendlabs / openraft

rust raft with improvements
Apache License 2.0
1.41k stars 158 forks source link

Migrate Rust toolchain action from `actions-rs/toolchain` to an action that is still maintained #1217

Open SteveLauC opened 4 months ago

SteveLauC commented 4 months ago

Just found that we are still using actions-rs/toolchain and actions-rs/cargo in the CI, they have already been archived, we should switch to an action that is maintained, e.g., dtolnay/rust-toolchain.

actions-rs/toolchain has an override parameter which is not provided by dtolnay/rust-toolchain, but we can do it manually:

      - name: Setup | Override toolchain
        run: rustup override set ${{ matrix.toolchain }}

actions-rs/cargo has a feature that is not supported by dtolnay/rust-toolchain as well, if we don't rely on this, we can simply invoke cargo manually:

  1. Warnings and errors issued by cargo will be displayed in GitHub UI
github-actions[bot] commented 4 months ago

👋 Thanks for opening this issue!

Get help or engage by: