databricks / click

The "Command Line Interactive Controller for Kubernetes"
Apache License 2.0
1.49k stars 84 forks source link

the trait bound `TableColor: From<crossterm::style::Color>` is not satisfied #218

Open jiayingwang-db opened 1 year ago

jiayingwang-db commented 1 year ago

Hi, I might these 2 errors when installing Click on my laptop, could someone help to take a look?

error[E0277]: the trait bound `TableColor: From<crossterm::style::Color>` is not satisfied
  --> /Users/xxx.cargo/registry/src/github.com-1ecc6299db9ec823/click-0.6.2/src/command/click.rs:59:55
   |
59 |                 Some(env.styles.context_table_color().into()),
   |                                                       ^^^^ the trait `From<crossterm::style::Color>` is not implemented for `TableColor`
   |
   = help: the following other types implement trait `From<T>`:
             <TableColor as From<ColorType>>
             <TableColor as From<comfy_table::Color>>
   = note: required for `crossterm::style::Color` to implement `Into<TableColor>`

error[E0308]: mismatched types
  --> /Users/xxx/.cargo/registry/src/github.com-1ecc6299db9ec823/click-0.6.2/src/table.rs:65:36
   |
61 |     fn to_color(&self, env: &Env) -> Color {
   |                                      ----- expected `comfy_table::Color` because of return type
...
65 |                 ColorType::Info => env.styles.info_color(),
   |                                    ^^^^^^^^^^^^^^^^^^^^^^^ expected `comfy_table::Color`, found `crossterm::style::Color`
   |
   = note: `crossterm::style::Color` and `comfy_table::Color` have similar names, but are actually distinct types
note: `crossterm::style::Color` is defined in crate `crossterm`
  --> /Users/xxx/.cargo/registry/src/github.com-1ecc6299db9ec823/crossterm-0.25.0/src/style/types/color.rs:28:1
   |
28 | pub enum Color {
   | ^^^^^^^^^^^^^^
note: `comfy_table::Color` is defined in crate `crossterm`
  --> /Users/xxx/.cargo/registry/src/github.com-1ecc6299db9ec823/crossterm-0.26.1/src/style/types/color.rs:28:1
   |
28 | pub enum Color {
   | ^^^^^^^^^^^^^^
   = note: perhaps two different versions of crate `crossterm` are being used?

Some errors have detailed explanations: E0277, E0308.
For more information about an error, try `rustc --explain E0277`.
error: could not compile `click` due to 2 previous errors
error: failed to compile `click v0.6.2`, intermediate artifacts can be found at `/var/folders/04/jlt2yd8n07x9np7x2lph9ghh0000gp/T/cargo-installuJD6gf`
adiram359 commented 1 year ago

click is also part of universe at bin/click.

dsiddharth commented 1 year ago

@nicklan we're running into the same issue when trying to install latest click as well

rock-lucasnascin commented 1 year ago

same here

ryaminal commented 1 year ago

cloning the repo and doing cargo build works fine and can certainly use the prebuilt binaries, but it's strange that cargo install isn't working.

edit: oh, cargo install ignores the lock... interesting. cargo build in the repo uses crossterm v0.26.1 but the cargo install uses v0.25.0 and v0.26.1... not certain how to fix but likely the problem.

libratiger commented 1 year ago

same issue

hasnain-db commented 10 months ago

hm, I'm unable to repro this on the latest rust/cargo version (1.75.0). if anyone here can still reproduce this please let me know

hasnain-db commented 10 months ago

https://github.com/rust-lang/cargo/issues/7169 suggests cargo install click --locked is the right fix for this.

If this pops up again with more people affected we could update the readme. What do you think, @nicklan ?