databricks / spark-corenlp

Stanford CoreNLP wrapper for Apache Spark
GNU General Public License v3.0
422 stars 120 forks source link

Shade protobuf and release the assembly jar #38

Closed mengxr closed 6 years ago

mengxr commented 6 years ago

v0.3.0 doesn't work on Spark 2.3 because the latter has protobuf 2.x while CoreNLP 3.9.1 depends on protobuf 3.x.

This PR changes build to create an assembly jar with protobuf shaded. We cannot shade CoreNLP because it seems using reflection. Other transitive dependencies are kept. We might need to improve shading in a follow-up work.

Closes #37