search

databricks / terraform-databricks-sra

The Security Reference Architecture (SRA) implements typical security features as Terraform Templates that are deployed by most high-security organizations, and enforces controls for the largest risks that customers ask about most often.
Other
125 stars 56 forks source link

[AWS] Documentation Fix #139

Closed T-Omii closed 3 days ago

T-Omii commented 1 month ago

  1. According to the Databricks documentation, the customer-managed key (CMK) encryption use cases are listed as “Workspace storage” and “Managed services.” However, in aws/tf/modules/sra/cmk.tf, these use cases appear as workspace_storage and managed_storage. This seems inconsistent with the documentation. Would it be more appropriate to rename managed_storage to managed_services?https://github.com/databricks/terraform-databricks-sra/blob/ebc57958b233ccc00e9b5d942fa2d78be8ba26dd/aws/tf/modules/sra/cmk.tf#L77-L123

  2. The README still includes references to the older term “data plane.” Since this is now referred to as the “compute plane,” it would be great to update those references for clarity.

If this issue is valid, I’m happy to open a PR to address these changes.

jdbraun-db commented 1 month ago

Thanks @T-Omii good catch in both! I'll snag these in my next PR.

jdbraun-db commented 3 days ago

153